convert ServiceTemplate.orderable? to supports?(:order)

[kbrock]

Part of bigger:

• Use supports in more instances manageiq#21989

depends upon:

• transition supports_orderable? to support?(:order) manageiq#22902

Overview

This is the second attempt at #9071

Now that ServiceTemplates and ServiceOrders both offer supports :order, dropping orderable? and using the standard supports.

[kbrock]

will kick once other PR is merged

[agrare]

Suggested change

	if @record.orchestration_template.supports(:order)
	if @record.orchestration_template.supports?(:order)

[kbrock]

ugh. both prs got confused with supports?(:orderable), support(:order) and the correct supports?(:order)

update:

• rebase
• fixed support call

[kbrock]

update:

• rebase (just updating - no real change)

@agrare If you don't see anything wrong, this is ready to go

[miq-bot]

Checked commit kbrock@8a51b79 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
5 files checked, 9 offenses detected

app/helpers/application_helper/button/orchestration_template_orderable.rb

• ❗ - Line 3, Col 5 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 3, Col 65 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.

app/helpers/application_helper/button/orchestration_template_view_in_catalog.rb

• ❗ - Line 3, Col 5 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.
• ❗ - Line 3, Col 65 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.

app/views/orchestration_stack/_stack_orchestration_template.html.haml

• 💣 💥 🔥 🚒 - Line 1 - Do not repeat id "#form_div" on the page
• 💣 💥 🔥 🚒 - Line 32 - Do not repeat id "#form_div" on the page
• ⚠️ - Line 22 - Avoid using instance variables in partials views
• ⚠️ - Line 24 - Avoid using instance variables in partials views
• ⚠️ - Line 24 - Line is too long. [89/80]