Inbox upgrade #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Added the three main objects for the multi-sort. Include DOC, LAB, HRM. These can have multiple selected at the same time. *Can be viewed by navigating to /oscar/web/inboxhub/InboxManager.do?method=displayInboxForm
* Sorted all null or empty values to bottom to be more in line with previous inbox.
*Split up new inbox files. *Added document counts for docs, labs, unmatched, abnormal, normal. *Added date search using jQuery DatePicker
* Changed code formatting & css. * Removed css on forward modal. * Added new inbox to the main menu.
…existing DastabTable-1.13.4 that is in master branch alrealdy.
…er resizing winddow
ctrl + click is not open the popup of new tab in firefox browser
|
@sourcery-ai review |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @lacarmen - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider standardizing on modern UI frameworks rather than mixing jQuery with Bootstrap 5. This will improve maintainability and reduce technical debt.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…is open, the user cannot refresh it from another document.
…n per entry within each paginated set of 20 results.
…M count is greater than 0
D3V41
force-pushed
the
feature/inbox-final
branch
from
cbc959c to
3676c47
Compare
D3V41
force-pushed
the
feature/inbox-final
branch
from
3676c47 to
a0097c1
Compare
lacarmen
pushed a commit
that referenced
this pull request
Jan 15, 2025
Added development-drugref.sql
…box and add the Label column
…dth` as optional parameters, with default values of 700 and 1215 respectively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Upgrade the inbox system by introducing the Inboxhub feature, which provides enhanced filtering and viewing capabilities for inbox items. Improve the UI of the provider selection form and refactor HRM document count logic to support abnormal status filtering. Update user-facing documentation in multiple languages to reflect these changes.
New Features:
Enhancements:
Documentation: