Fix/url #1349
Merged
Fix/url #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix URL and Signature Encoding for Object Listing
Problem:
The CLI was failing with 403 Forbidden - AccessDenied when listing objects with spaces in the prefix. This happened because:
Spaces were encoded as "+" instead of "%20", causing malformed URLs.
QueryEscape was used for signature encoding, leading to authentication mismatches.
Solution:
Replaced "+" with "%20" in URL encoding.
Switched from QueryEscape to PathEscape for signature encoding, ensuring correct request formatting.
How Has This Been Tested?
Unit Tests: Describe the unit tests you have written and their outcomes.
Integration Tests: Detail the integration tests performed and their results.
Manual Testing: Explain the manual testing process, including steps taken and evidence such as screenshots or logs.
Checklist
pre-commit run --all-filesScreenshots/Videos