fix: removing plan modifiers from terraform fields with UseStateForUn…

…kown that are dynamic (#1275) * fix: removing plan modifiers from terraform fields with UseStateForUnkown that are dynamic * chore: fix lint
MagaluCloud · Dec 2, 2024 · 4f501a0 · 4f501a0
1 parent 44ba8c0
commit 4f501a0
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 20 deletions.
diff --git a/mgc/terraform-provider-mgc/mgc/resources/mgc_bs_snapshots.go b/mgc/terraform-provider-mgc/mgc/resources/mgc_bs_snapshots.go
@@ -123,10 +123,7 @@ func (r *bsSnapshots) Schema(_ context.Context, _ resource.SchemaRequest, resp *
 			},
 			"final_name": schema.StringAttribute{
 				Description: "The final name of the volume snapshot after applying any naming conventions or modifications.",
-				PlanModifiers: []planmodifier.String{
-					stringplanmodifier.UseStateForUnknown(),
-				},
-				Computed: true,
+				Computed:    true,
 			},
 			"updated_at": schema.StringAttribute{
 				Description: "The timestamp when the block storage was last updated.",

diff --git a/mgc/terraform-provider-mgc/mgc/resources/mgc_bs_volumes.go b/mgc/terraform-provider-mgc/mgc/resources/mgc_bs_volumes.go
@@ -118,17 +118,13 @@ func (r *bsVolumes) Schema(_ context.Context, _ resource.SchemaRequest, resp *re
 			"name": schema.StringAttribute{
 				Description: "The name of the block storage.",
 				PlanModifiers: []planmodifier.String{
-					stringplanmodifier.UseStateForUnknown(),
 					stringplanmodifier.RequiresReplace(),
 				},
 				Required: true,
 			},
 			"final_name": schema.StringAttribute{
 				Description: "The final name of the block storage after applying any naming conventions or modifications.",
-				PlanModifiers: []planmodifier.String{
-					stringplanmodifier.UseStateForUnknown(),
-				},
-				Computed: true,
+				Computed:    true,
 			},
 			"snapshot_id": schema.StringAttribute{
 				Description: "The unique identifier of the snapshot used to create the block storage.",

diff --git a/mgc/terraform-provider-mgc/mgc/resources/mgc_vm_instances.go b/mgc/terraform-provider-mgc/mgc/resources/mgc_vm_instances.go
@@ -139,10 +139,7 @@ func (r *vmInstances) Schema(_ context.Context, _ resource.SchemaRequest, resp *
 			},
 			"final_name": schema.StringAttribute{
 				Description: "The final name of the virtual machine instance after applying any naming conventions or modifications.",
-				PlanModifiers: []planmodifier.String{
-					stringplanmodifier.UseStateForUnknown(),
-				},
-				Computed: true,
+				Computed:    true,
 			},
 			"updated_at": schema.StringAttribute{
 				Description: "The timestamp when the virtual machine instance was last updated.",
@@ -221,10 +218,7 @@ func (r *vmInstances) Schema(_ context.Context, _ resource.SchemaRequest, resp *
 					},
 					"name": schema.StringAttribute{
 						Description: "The name of the machine type.",
-						PlanModifiers: []planmodifier.String{
-							stringplanmodifier.UseStateForUnknown(),
-						},
-						Required: true,
+						Required:    true,
 					},
 					"disk": schema.NumberAttribute{
 						Description: "The disk size of the machine type.",

diff --git a/mgc/terraform-provider-mgc/mgc/resources/mgc_vm_snapshots.go b/mgc/terraform-provider-mgc/mgc/resources/mgc_vm_snapshots.go
@@ -85,9 +85,8 @@ func (r *vmSnapshots) Schema(_ context.Context, _ resource.SchemaRequest, resp *
 				Required:            true,
 			},
 			"updated_at": schema.StringAttribute{
-				Description:   "The timestamp when the snapshot was last updated.",
-				Computed:      true,
-				PlanModifiers: []planmodifier.String{stringplanmodifier.UseStateForUnknown()},
+				Description: "The timestamp when the snapshot was last updated.",
+				Computed:    true,
 			},
 			"created_at": schema.StringAttribute{
 				Description:   "The timestamp when the snapshot was created.",