Update "format" so that control characters are escaped in a JSON-friendly way #3677
+95
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, escape them in a JSON-friendly way, i.e., use the shorter forms for \b, \f, \n, \r, and \t only. All other others are escaped as \u00xy. Also add some new char arithmetic functions to make the code a bit cleaner.
Regular old "present" now does a better job
mahrud
reviewed
Mar 6, 2025
| else if c == '\f' then (provide '\\'; provide 'f') | ||
| else if c == '\n' then (provide '\\'; provide 'n') | ||
| else if c == '\r' then (provide '\\'; provide 'r') | ||
| else if c == '\t' then (provide '\\'; provide 't') | ||
| else if c == '\v' then (provide '\\'; provide 'v') | ||
| else if 0 <= c && c < 32 | ||
| then ( -- escape all other control characters as \u00xy |
There was a problem hiding this comment.
This is probably fine, but you should probably add some tests or otherwise document the behavior somewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick follow-up to #3670. Now
formatplays nicely with JSON for control characters:Closes: #3673