Decrease indentation when line begins with a right paren #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't called anywhere else. Also add a docstring and simplify the code.
If the first character in the current line is a right paren, then we decrease the indentation. But to offset this, we need to increase the indentation when the first character in the previous line is a right paren. Also merge the otherwise unused function M2-next-line-indent-amount into M2-this-line-indent-amount.
Its keybinding to "}" has been commented out for ages, but it will be very useful for re-indenting lines that begin with a right paren. In addition to "}", we also bind it to ")" and "]". We also remove it from the menu since it's useless without typing a specific key.
|
Amazing! In lieu of a review I will test drive this for a while and report back! |
|
So far happy with this. As long as nobody else is opposed to this change, I'm happy to merge this. |
|
Things are working okay, but I'm getting pretty annoyed when editing older code. For instance say I start with an old code f = x -> (
2 * x
)
<-- pointer hereThen I press enter to make a new line and add a new function, auto indent gives me: f = x -> (
2 * x
)
g = x -> (
)On the other hand, say I start fresh with: f = x -> (
x = 2 * x;) <-- pointer here before the parenthesisThen I press enter to make a new line and add a new statement, this happens: f = x -> (
x = 2 * x;
return x) <-- pointer end up here, before the parenthesisNow if I press tab I get: f = x -> (
x = 2 * x;
return x ) <-- pointer end up here, before the parenthesisWhich isn't what I wanted ... I need to jump to beginning of the line then tab to indent it correctly. Not totally sure if these are fixable, but you might know of another option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #77, we decrease the indentation when indenting a line that opens with a
),], or}. We also revive the unusedM2-electric-right-bracefunction so that we re-indent automatically when typing one of these characters.