Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #335

Merged
merged 71 commits into from
Sep 5, 2024
Merged
Changes from 1 commit
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
94bc285
fix: stretch content's container in OperationCard
Handiwork Jul 2, 2024
fcbf917
Merge pull request #319 from Handiwork/dev
guansss Jul 5, 2024
1525800
temp storage
Gemini2035 Jul 9, 2024
c3f92e5
chore: update generated assets [skip ci]
GalvinGao Jul 9, 2024
70470a4
Merge pull request #320 from MaaAssistantArknights/scripts/update
GalvinGao Jul 9, 2024
907af4a
temp storage
Gemini2035 Jul 11, 2024
4b97b99
temp storage
Jul 11, 2024
2bfbfba
Merge pull request #3 from GeorgeZhang2035/perf/sheet
Gemini2035 Jul 11, 2024
faf0685
perf: operatoritem refactor
Jul 12, 2024
8bc80ac
feat: operator item completed
Jul 12, 2024
03bd8d6
Merge pull request #4 from GeorgeZhang2035/perf/sheet
Gemini2035 Jul 12, 2024
0f88b39
temp storage
Gemini2035 Jul 15, 2024
8ca11b7
temp storage
Jul 15, 2024
6d491c2
Merge pull request #5 from GeorgeZhang2035/perf/sheet
Gemini2035 Jul 16, 2024
3638045
temp storage
Gemini2035 Jul 16, 2024
c4c04aa
perf: code of filter by prof completed
Jul 16, 2024
d43af68
fix: bug fixed!
Jul 16, 2024
b621f6d
perf: part of pagination refacted
Jul 16, 2024
1121264
Merge pull request #6 from GeorgeZhang2035/perf/sheet
Gemini2035 Jul 16, 2024
6b989d2
perf: dataTotal about optimized
Gemini2035 Jul 16, 2024
0ed2e80
chore: update generated assets [skip ci]
GalvinGao Jul 16, 2024
e5f5527
temp storage
Gemini2035 Jul 17, 2024
3b42d77
perf: filter about refacted
Jul 17, 2024
e5ae8a1
fix: emergency bug fixed
Jul 17, 2024
b0b40e9
temp storga
Jul 17, 2024
eab9eb5
Merge pull request #7 from GeorgeZhang2035/perf/sheet
Gemini2035 Jul 17, 2024
798adad
mutiple select completed
Gemini2035 Jul 17, 2024
ec589d6
feat: back to top button completed!
Gemini2035 Jul 17, 2024
56a350d
temp storage
Gemini2035 Jul 17, 2024
8557c1a
feat: back to top button completed!
Gemini2035 Jul 18, 2024
6e34afd
feat: rarity select ready
Jul 18, 2024
28c46fa
temp storage
Jul 18, 2024
28a4c79
Merge pull request #8 from GeorgeZhang2035/perf/sheet
Gemini2035 Jul 18, 2024
ad21b50
temp storage
Gemini2035 Jul 19, 2024
ea0b251
temp storage
Jul 19, 2024
8bd95e3
fix: some bugs in group fixed
Jul 22, 2024
9df7256
temp storage
Jul 22, 2024
4ef590d
Merge pull request #9 from GeorgeZhang2035/perf/sheet
Gemini2035 Jul 22, 2024
b71c847
temp storage
Jul 23, 2024
5d1c634
Merge pull request #10 from GeorgeZhang2035/perf/sheet
Gemini2035 Jul 23, 2024
e3cd8f5
feat: ui of operator selector completed
Gemini2035 Jul 23, 2024
7c68c1e
temp storage
Jul 24, 2024
77dc64f
Merge pull request #11 from GeorgeZhang2035/perf/sheet
Gemini2035 Jul 24, 2024
eb233f9
Revert "temp storage"
GeorgeZhang2035 Jul 26, 2024
82b1fb1
Merge pull request #12 from GeorgeZhang2035/revert-11-perf/sheet
Gemini2035 Jul 26, 2024
240d78f
Revert "Revert "temp storage""
Gemini2035 Jul 26, 2024
cc16c41
Merge pull request #13 from Gemini2035/revert-12-revert-11-perf/sheet
Gemini2035 Jul 26, 2024
106e5dc
feat: onSubmit ready
Jul 26, 2024
e814442
temp storage
Jul 26, 2024
59a0861
fix(accountmenu): update nav bar display
martinwang2002 Jul 26, 2024
1955168
Merge pull request #14 from GeorgeZhang2035/perf/sheet
Gemini2035 Jul 26, 2024
847c116
feat: func ready
Gemini2035 Jul 26, 2024
faba50e
lint-fix: make eslint happy
Handiwork Jul 27, 2024
6b194c8
perf: code about sheet refactor
Gemini2035 Jul 27, 2024
e86aeb1
code about sheet refacted
Gemini2035 Jul 27, 2024
ca1994e
fix: prof image 404 fixed
Gemini2035 Jul 27, 2024
089d017
chore: update generated assets [skip ci]
GalvinGao Aug 1, 2024
7344538
Merge pull request #324 from MaaAssistantArknights/scripts/update
GalvinGao Aug 1, 2024
b4a125d
Merge pull request #323 from Gemini2035/perf/sheetAbout
guansss Aug 4, 2024
83972fb
chore: update generated assets [skip ci]
GalvinGao Aug 5, 2024
1ee4093
Merge pull request #325 from MaaAssistantArknights/scripts/update
GalvinGao Aug 6, 2024
58b97af
build: update assets on main
GalvinGao Aug 6, 2024
56caac5
chore: update typescript
GalvinGao Aug 6, 2024
b923eb0
Revert "build: update assets on main"
guansss Aug 9, 2024
ee9ce82
chore: update generated assets [skip ci]
GalvinGao Sep 2, 2024
0943482
Merge pull request #334 from MaaAssistantArknights/scripts/update
GalvinGao Sep 3, 2024
00f1b22
feat: pages index sticky
fundgao Sep 4, 2024
7deab45
Merge pull request #337 from fundgao/dev
Handiwork Sep 4, 2024
af646b4
feat: 添加支持作者评论字数上限为500
dragove Sep 5, 2024
bd573d6
refactor: default max length for comment form
guansss Sep 5, 2024
b285b61
Merge pull request #338 from dragove/dev
guansss Sep 5, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: default max length for comment form
guansss committed Sep 5, 2024
commit bd573d66623659380466a8948c0b620386b21816
7 changes: 4 additions & 3 deletions src/components/viewer/comment/CommentForm.tsx
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@ import { sendComment } from 'apis/comment'
import clsx from 'clsx'
import { useContext, useState } from 'react'

import { MAX_COMMENT_LENGTH } from '../../../models/comment'
import { formatError } from '../../../utils/error'
import { wrapErrorMessage } from '../../../utils/wrapErrorMessage'
import { Markdown } from '../../Markdown'
@@ -23,7 +24,7 @@ export const CommentForm = ({
primary,
placeholder = '发一条友善的评论吧',
inputAutoFocus,
maxLength,
maxLength = MAX_COMMENT_LENGTH,
}: CommentFormProps) => {
const { operationId, replyTo, reload } = useContext(CommentAreaContext)

@@ -83,7 +84,7 @@ export const CommentForm = ({
rows={2}
growVertically
large
maxLength={maxLength ?? 150}
maxLength={maxLength}
placeholder={placeholder}
value={message}
onChange={(e) => setMessage(e.target.value)}
@@ -112,7 +113,7 @@ export const CommentForm = ({
</Checkbox>

<div className="ml-auto text-slate-500 text-sm">
{message.length}/{maxLength ?? 150}
{message.length}/{maxLength}
</div>
</div>