-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated boxes support #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cconcolato do you see any deprecated boxes in this list? (note that a lot of those below are brands / handlers and they are already handled in #101 and #102, but if you see any deprecated ones we should try to add them in this PR if possible.
I added the deprecated from ISOBMFF in c955f41 but didn't check others. Related: MPEGGroup/FileFormat#79 Update
|
we should also incorporate the outcome of MPEGGroup/FileFormat#47 I believe we can remove: {
"fourcc": "svop",
"description": "SVC dependency range",
"containers": ["sgpd"],
"type": "Box",
"syntax": "class SVCDependencyRangeBox extends Box('svop') {\n\tunsigned int(3) min_dependency_id;\n\tunsigned int(3) min_temporal_id;\n\tbit(6) reserved = 0;\n\tunsigned int(4) min_quality_id;\n\tunsigned int(3) max_dependency_id;\n\tunsigned int(3) max_temporal_id;\n\tbit(6) reserved = 0;\n\tunsigned int(4) max_quality_id;\n}"
}, as we already have: {
"fourcc": "svdr",
"description": "SVC dependency range",
"containers": ["scif"],
"type": "Box",
"syntax": "class SVCDependencyRangeBox extends Box('svdr') {\n\tunsigned int(3) min_dependency_id;\n\tunsigned int(3) min_temporal_id;\n\tbit(6) reserved = 0;\n\tunsigned int(4) min_quality_id;\n\tunsigned int(3) max_dependency_id;\n\tunsigned int(3) max_temporal_id;\n\tbit(6) reserved = 0;\n\tunsigned int(4) max_quality_id;\n}"
}, |
Should we deprecate it instead of removing? |
no, this was added by mistake. I believe it was a typo in the spec |
Is this related to #67? |
@podborski Should we merge this or would you like to keep it open to add all the deprecated boxes? |
fixes #72
The support for deprecated boxes has been added. When all deprecated boxes are added to this PR we can merge it.