Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to overwrite file (and write out extra files with "verbose") in T2smap workflow #1166

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Add option to overwrite file (and write out extra files with "verbose") in T2smap workflow #1166

merged 2 commits into from
Jan 16, 2025

Conversation

smoia
Copy link
Collaborator

@smoia smoia commented Jan 15, 2025

Closes [I don't know if there was an issue open for this].

Changes proposed in this pull request:

  • T2smap workflow currently does not allow to overwrite files - but stops with runtime error if a file would be overwritten, asking to use the non-existing --overwrite argument. This PR solves that issue.
  • I saw that in the tedana workflow parser, "overwrite" was added to the parser itself rather than to the "optional" parser group, so just quickly changed that, if desirable.

@smoia smoia added the bug issues describing a bug or error found in the project label Jan 15, 2025
eurunuela
eurunuela approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurunuela
Copy link
Collaborator

@smoia, did you end up finishing #644? Is it at a state where we could just get it up to date with main?

@smoia
Copy link
Collaborator Author

smoia commented Jan 16, 2025

@eurunuela TBH I totally lost track of that. I can have a look at it this weekend, would that work for you?

@eurunuela eurunuela requested a review from tsalo January 16, 2025 10:49
@eurunuela
Copy link
Collaborator

@eurunuela TBH I totally lost track of that. I can have a look at it this weekend, would that work for you?

That would be very much appreciated!

tsalo
tsalo approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

@eurunuela eurunuela merged commit 213eead into ME-ICA:main Jan 16, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurunuela eurunuela eurunuela approved these changes

@tsalo tsalo tsalo approved these changes

Assignees
No one assigned
Labels
bug issues describing a bug or error found in the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smoia @eurunuela @tsalo