Skip to content

Commit

Permalink
Address Yarik's review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
emdupre committed Nov 2, 2018
1 parent 3e47616 commit 7d5d708
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
6 changes: 4 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ We also maintain a [gitter chat room][link_gitter] for more informal conversatio
There is significant cross-talk between these two spaces, and we look forward to hearing from you in either venue!
As a reminder, we expect all contributions to `tedana` to adhere to our [code of conduct][link_coc].

## Explaining issues, milestones and project boards
## Understanding issues, milestones and project boards

Every project on GitHub uses [issues][link_issues], [milestones][link_milestones],
and [project boards][link_project_boards] slightly differently.
Expand Down Expand Up @@ -110,7 +110,9 @@ When opening a pull request, please use at least one of the following prefixes:
* **[TST]** for new or updated tests
* **[DOC]** for new or updated documentation
* **[STY]** for stylistic changes
* **[RF]** for refactoring existing code
* **[REF]** for refactoring existing code
* **[BRK]** for changes which break existing builds or tests
* **[WIP]** for changes which are not yet ready to be merged

Pull requests should be submitted early and often!
If your pull request is not yet ready to be merged, please also include the **[WIP]** prefix.
Expand Down
2 changes: 1 addition & 1 deletion docs/contributing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ during any interaction with the project.
That includes---but is not limited to---online conversations,
in-person workshops or development sprints, and when giving talks about the software.

As is stated in the code, severe or repeated violations by community members may result in exclusion
As it is stated in the code, severe or repeated violations by community members may result in exclusion
from collective decision-making and rejection of future contributions to the ``tedana`` project.

.. _code of conduct: https://github.com/ME-ICA/tedana/blob/master/Code_of_Conduct.md
Expand Down
2 changes: 1 addition & 1 deletion docs/roadmap.rst
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ the existing implementation.
Moving forward, we want to grow an active development community,
where developers feel empowered to explore new enhancements to the ``tedana`` code base.

One means to ensure that new code does not introduce silent failures is through extensive testing.
One means to ensure that new code does not introduce bugs is through extensive testing.
We are therefore committed to implementing high test coverage at both
the unit test and integration test levels;
that is, both in testing individual functions and broader workflows, respectively.
Expand Down

0 comments on commit 7d5d708

Please sign in to comment.