Remove python 2 support from ckbytelist constructor #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
ckbytelist
constructor checks python version for every byte in a loop:which is redundant and not good for performance. I suppose, just checking python version once during module import would suffice. This PR removes support of python 2 from
ckbytelist
class, since python 2 is not supported anymore.The performance issue can be illustrated with a simple benchmark command:
For instance, on my system it now runs about six times faster compared to master.