Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Event General End Time based on server time + modify Gacha task on reaching time limit #4633

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

dragonheart107
Copy link
Contributor

Partial feature of #4526

this should allow for the input of the in game notification for the event ending timer and additionally will not disable gacha task and instead modifies it to 1 pull from light.

However if Gacha task is triggered before the other event tasks it will do the gacha as normal without stopping and event time limit will only be triggered if the other event tasks are run. How/where would I need to modify, so that it already stops on gacha too and does the disable task chain.

@LmeSzinc
Copy link
Owner

LmeSzinc commented Mar 5, 2025

  1. EventGeneral_TimeLimit is a manual input value, it is supposed to be a local time to prevent calculations in human brain
  2. Current gacha task will auto fallback to light pool if event is unavailable, which I think better as it's a once-and-done setting, user don't bother changing it every event

@LmeSzinc LmeSzinc added the optimization / 优化 Improve robustness or increase speed label Mar 5, 2025
@dragonheart107
Copy link
Contributor Author

dragonheart107 commented Mar 5, 2025

  1. EventGeneral_TimeLimit is a manual input value, it is supposed to be a local time to prevent calculations in human brain

    1. Current gacha task will auto fallback to light pool if event is unavailable, which I think better as it's a once-and-done setting, user don't bother changing it every event

for 1. this is only true though if you are playing within the same time zone of your server, where local = server time; however while this is largely true for cn / jp players globals has too many different timezones; with the change you now need to only input the time mentioned in the in game announcements when a event is ending, as ALAS then checks if the server time has been exceeded by local time, no need for calculations anymore

for 2. i guess that would be fine, however the amount of pulls doesn't get changed at the moment, no? If so, then move the config setting over to gacha_reward.py or even into def gacha_goto_pool(self, target_pool) ? Also, does it currently change the config if it can't pull from event pool? or does it just do the whole wrong target pool loop whenever gacha task is executed?

@dragonheart107
Copy link
Contributor Author

dragonheart107 commented Mar 5, 2025

 if target_pool == 'wishing_well':
           if self._gacha_side_navbar.get_total(main=self) != 5:
               logger.warning('\'wishing_well\' is not available, '
                              'default to \'light\' pool')
               target_pool = 'light'
               #self.config.cross_set(keys=f'Gacha.Gacha.Amount', value= 1)
               self.config.__setattr__(value=1)

would self.config.__setattr__(value=1) work if added to gacha-goto-pool to not only default to light but also set pull amount to one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization / 优化 Improve robustness or increase speed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants