Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sidebar sticky #26

Merged
merged 2 commits into from
May 31, 2024
Merged

Make sidebar sticky #26

merged 2 commits into from
May 31, 2024

Conversation

milanmlft
Copy link
Collaborator

@milanmlft milanmlft commented May 29, 2024 •
edited
Loading

Fixes #24

To test, run the following inside a sandpaper lesson's directory in R:

remotes::install_github("LearnToDiscover/varnish@l2d-sticky-sidebar")
sandpaper::build_lesson()

sabaferdous12
sabaferdous12 approved these changes May 31, 2024
View reviewed changes
Copy link

@sabaferdous12 sabaferdous12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks absolutely great.. Thank you Milan..

@milanmlft milanmlft merged commit 593fa51 into main May 31, 2024
@milanmlft milanmlft deleted the l2d-sticky-sidebar branch May 31, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabaferdous12 sabaferdous12 sabaferdous12 approved these changes

@DrAdamLee DrAdamLee Awaiting requested review from DrAdamLee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the side menu 'sticky' when scrolling
3 participants
@milanmlft @sabaferdous12 @actions-user