Dupla colaborativa: Olimpia Coria- Dianyela Maldonado #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…có archivo readme.md y se gregaron imagenes a la carpeta readme
… del prototipo final
…habia agregado una letra de más, por eso no se reflejaban al querer verlas
…sus respectivas tareas.
Feature/cambios readme
…gen del backgraund se anexó logo de app cambios en index.html botones
se agregó logo faltante de la app en readme.md
…para tablet y movil
… style.css se le dieron estilos al slider, en main.js se hizo la funcion a los botones next y prev para la funcionalidad del slider
cambios realizados en index.html, se añadió información para slider, y…
…lta botonera de filtrar
cambios realizados en style.css en cuanto al responsive de la app, fa…
…ponsive-readme se añadieron cambios en readme.md intentando cargar imagen
… totalmente funcional
se añadieron cambios en data.js y en index.html la función del filtro…
…ototipo en baja 2
…idad en responsive, visible al 100% en desktop, tablets y móvil
se agregaron cambios en dat.js en links de imagenes para la funcional…
se agrego nueva línea de código al archivo data.js
se añadió letra S al http en data.js
…final-link Feacture/readme cambio final link
AdrianaHY
reviewed
Mar 29, 2020
docs/data.js
Outdated
| @@ -43,7 +43,7 @@ function cargarJSON() { //esta función hace la conexión y definimos como quere | |||
|
|
|||
| function cargarJSONdos(nombreCampeon) { | |||
| let onlyChampion = document.querySelector('#onlyChampion'); | |||
There was a problem hiding this comment.
Por qué se hacen dos peticiones?
AdrianaHY
reviewed
Mar 29, 2020
src/data.js
Outdated
| } | ||
| cardsprueba.innerHTML = html; | ||
| //console.log(html); | ||
| }) |
There was a problem hiding this comment.
Muy buen trabajo! Solo me queda una duda, por qué la interacción con el dom está en este archivo?
AdrianaHY
reviewed
Mar 29, 2020
src/data.js
Outdated
| @@ -6,7 +6,7 @@ document.addEventListener("DOMContentLoaded", function() { | |||
|
|
|||
| function cargarJSON() { //esta función hace la conexión y definimos como queremos que los devuleva, ya sea como texto JSON u otros metodos | |||
| let cardsprueba = document.querySelector('#cardsprueba'); | |||
| fetch('http://localhost:5000/data/lol/lol.json') | |||
| fetch('http://localhost:64127/data/lol/lol.json') | |||
| .then(res => { | |||
| return res.json() | |||
There was a problem hiding this comment.
Por qué hacemos una llamada al localhost?
AdrianaHY
reviewed
Mar 29, 2020
| </header> | ||
| <!-- slider --> | ||
|
|
||
| <section id="top"> |
There was a problem hiding this comment.
Borrar espacions y comentarios innecesarios.
AdrianaHY
reviewed
Mar 29, 2020
| <li> <button class="filter" data-type="Tank"> TANK<img class="b6" src="imagenes/tank2.png"> </button> </li> | ||
| <li> <button class="filter" data-type="All"> ALL CHAMPS<img class="b7"> </button> </li> | ||
| </ul> | ||
| </nav> |
There was a problem hiding this comment.
Hay que ser más consistentes con los espacios.
AdrianaHY
reviewed
Mar 29, 2020
…ere together in data.js, the code is modularized.
main.js load jsonone.js filterchamps.js variables that were written with var to let were replaced, and line 5 of filterchamps.js declared filteredChamps.
…de-restructuring Feature/new changes code restructuring
…de-restructuring move position of image in readme.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proyecto: Data lovers.
App: On-Rankeds.
Información tomada de los datos propuestos para el proyecto, en este caso: League of legends.
Laboratoria.
Sede:CDMX.