pull request datalovers #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianaHY
reviewed
Mar 18, 2020
docs/data.js
Outdated
| @@ -21,7 +21,7 @@ export function filterWeak(elementoW) { | |||
| } | |||
| export function printData(cosaParaimprimir, printPalce) { | |||
| cosaParaimprimir.forEach((pokemons) => { | |||
There was a problem hiding this comment.
Evitemos el uso de nombres de variables como este, no es muy descriptivo.
There was a problem hiding this comment.
Me refiero a "cosaParaImprimir"
AdrianaHY
reviewed
Mar 18, 2020
| @@ -66,7 +66,7 @@ export function numberOfCandys() { | |||
|
|
|||
| function pokemonName() { | |||
| const showResulterPokemon = document.getElementById('result2'); | |||
| const putImagen = document.getElementById('imgPokedex'); | |||
| // const putImagen = document.getElementById('imgPokedex'); | |||
| const nameInserted = document.getElementById('NamePokemon2').value; | |||
There was a problem hiding this comment.
Código que no se utiliza, debemos borrarlo :)
AdrianaHY
reviewed
Mar 18, 2020
| expect(typeof candys).toBe('function'); | ||
| }); | ||
| it('desbería regresar el atributo candy_acount del arreglo cuando se escribe el nombre de un pokemon', () => { | ||
| it('should return candy_count from the array when you type the pokemons name', () => { |
There was a problem hiding this comment.
Excelente!!!! Que bueno que lo cambiaron a inglés! 💃
AdrianaHY
reviewed
Mar 18, 2020
| expect(typeof printData).toBe('function'); | ||
| }); | ||
| }); | ||
| describe('printInfoPokemon', () => { | ||
| it('debe ser una función', () => { | ||
| it('should be a function', () => { | ||
| expect(typeof printInfoPokemon).toBe('function'); |
There was a problem hiding this comment.
Que bueno que hayan hecho sus pruebas unitarias!! Muchas felicidades!!
AdrianaHY
reviewed
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.