Code Review #31
Open
Code Review #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianaHY
reviewed
Mar 29, 2020
src/index.html
Outdated
| <script type="text/javascript" src="https://www.gstatic.com/charts/loader.js"></script> | ||
| <!-- <script type="text/javascript" src="https://www.google.com/jsapi"></script> --> | ||
|
|
||
|
|
There was a problem hiding this comment.
Recuerda ser consistente con los espacios y eliminar los espacios y comentarios innecesarios.
AdrianaHY
reviewed
Mar 29, 2020
src/index.html
Outdated
|
|
||
| <!-- HOJA 2 --> | ||
|
|
||
| <section class="pag2" id="login"> |
AdrianaHY
reviewed
Mar 29, 2020
src/index.html
Outdated
|
|
||
|
|
||
|
|
||
| <div class="select"> |
AdrianaHY
reviewed
Mar 29, 2020
src/index.html
Outdated
| <option>2013</option> | ||
| <option>2014</option> | ||
| <option>2015</option> | ||
| <option>2016</option> |
There was a problem hiding this comment.
Me parece que una forma de optimizar esto es crear elementos dinámicos desde JS.
AdrianaHY
reviewed
Mar 29, 2020
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Que función tiene este archivo?
AdrianaHY
reviewed
Mar 29, 2020
|
|
||
| }; //CICLO FOR | ||
| return accDatos; | ||
|
|
There was a problem hiding this comment.
Recuerdas borrar los comentarios y el código que no se está utilizando, en la manera en la que está ahorita es muy difícil leerlo.
AdrianaHY
reviewed
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@HectorBlisS