Fabiola #25
Open
Fabiola #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
second try to merge with master
Merging changes
first page almost complete
modal styling
graphic in every indicator
HectorBlisS
suggested changes
Mar 25, 2020
src/indicators.html
Outdated
| @@ -67,32 +67,3 @@ <h3></h3> | |||
| <script type="module" src="indicators.js"></script> | |||
| </body> | |||
| </html> | |||
|
|
|||
There was a problem hiding this comment.
Bien por borrar comentarios y código sobrante
| @@ -154,12 +154,18 @@ const oneGraphic = () => { | |||
| }); | |||
| } | |||
|
|
|||
| const removeGraphic = () => { | |||
There was a problem hiding this comment.
Bien los nombres en ingles y el camelCase
| let graphicModal = document.getElementById("graphicModal"); | ||
| let eraseChild = graphicModal.lastChild; | ||
| graphicModal.removeChild(eraseChild); | ||
| } | ||
|
|
||
| const showGraphic = (indicator) => { | ||
| let toggleButtonFlag = false; |
There was a problem hiding this comment.
Esta variable nunca se usó
| let graphicModal = document.getElementById("graphicModal"); | ||
| let eraseChild = graphicModal.lastChild; | ||
| graphicModal.removeChild(eraseChild); | ||
| } | ||
|
|
||
| // When the user clicks (x) of the modal, close it | ||
| span.onclick = function() { |
There was a problem hiding this comment.
De preferencia usar addEventListener
| @@ -207,8 +203,7 @@ div, header, footer, section{ | |||
| padding: 0; | |||
| /* border: 1px solid #888;*/ | |||
| width: 60%; | |||
|
|
|||
| box-shadow: 0 4px 8px 0 rgba(0,0,0,0.2),0 6px 20px 0 rgba(0,0,0,0.19); | |||
| box-shadow: 0 8px 16px 0 rgba(0,0,0,0.4),0 10px 22px 0 rgba(0,0,0,0.25); | |||
Comment on lines
3
to
+10
|
|
||
| describe('example', () => { | ||
| describe('bankData', () => { | ||
|
|
||
| it('debería ser una función', () => { | ||
| expect(typeof example).toBe('function'); | ||
| expect(typeof bankData).toBe('function'); | ||
| }); | ||
|
|
||
| describe('example', () => { | ||
| //describe('example', () => { |
There was a problem hiding this comment.
Muy bien por agregr tests
| @@ -56,18 +49,14 @@ for (let i=0; i< indicatorName.length; i ++){ | |||
| aTwitter.setAttribute("href","https://twitter.com/share?url=<URL>&text=<TEXT>via=<USERNAME>"); | |||
| aFacebook.setAttribute("href","https://www.facebook.com/sharer/sharer.php?u=<URL>"); | |||
| aMail.setAttribute("href","mailto:?subject=<SUBJECT>&body=<BODY>"); | |||
There was a problem hiding this comment.
podrian intentar usar más `` para dibujar el html y mejorar la lectura
| let graphicModal = document.getElementById("graphicModal"); | ||
|
|
||
| let graphic = document.createElement("canvas"); | ||
| graphic.setAttribute("id","myChart"); |
| data:{ | ||
| labels:Object.keys(indicatorData), | ||
| datasets:[{ | ||
| label:'PER', |
There was a problem hiding this comment.
Bien el uso de graficas
| let graphicModal = document.getElementById("graphicModal"); | ||
| let eraseChild = graphicModal.lastChild; | ||
| graphicModal.removeChild(eraseChild); | ||
| removeGraphic(); | ||
| } | ||
|
|
||
| // When the user clicks anywhere outside of the modal, close it | ||
| window.onclick = function(event) { |
There was a problem hiding this comment.
Esto no es necesario si el script está al final de la etiueta body
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project name: Bars & Dots
Developers: Eliza Olmedo y Fabiola González