code review Data Lovers #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianaHY
reviewed
Mar 22, 2020
| <p> </p> | ||
| <nav> | ||
| <div class="element2"> | ||
| <link rel="stylesheet" href="https://www.w3schools.com/w3css/4/w3.css"> |
There was a problem hiding this comment.
Utilicemos clases más decriptivas, que por si sola me digan de que estamos hablando.
AdrianaHY
reviewed
Mar 22, 2020
src/index.html
Outdated
| </div> | ||
| <div class="centeredPrompt__item centeredPromptLabel">Pokédex</div> | ||
| <div class="centeredPrompt__item centeredPromptDetails"> | ||
| <p>Pokédex es una enciclopedia de alta tecnología que los Entrenadores Pokémon utilizan</br> para registrar las diversas especies con las que se encuentran durante su viaje como entrenadores.</br> |
There was a problem hiding this comment.
Hay que eliminar los espacios innecesarios.
AdrianaHY
reviewed
Mar 22, 2020
src/main.js
Outdated
| `; | ||
| container.appendChild(div); | ||
|
|
||
|
|
||
| }); | ||
| } | ||
| const electricType = list.filter((p) => p.type.includes('Electric')); | ||
| console.log(electricType); | ||
| const fireType = list.filter((p) => p.type.includes('Fire')); |
There was a problem hiding this comment.
Los console no deben subirse, solo nos sirven para debuggear.
AdrianaHY
reviewed
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.