Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix poddecoration concurrent map writes #309

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

Eikykun
Copy link
Collaborator

@Eikykun Eikykun commented Dec 2, 2024

concurrent map writes
I1127 11:41:34.103024       1 sync_control.go:406] collaset-controller "msg"="try to create Pod with revision of collaSet" "collaset"="e2e-tests-collaset-75392/collaset-2lrv67mrtc-inplaceifpossible" "revision"="collaset-2lrv67mrtc-inplaceifpossible-d4bb4649c"

goroutine 7004 [running]:
kusionstack.io/kuperator/pkg/controllers/utils/poddecoration.(*namespacedPodDecorationManager).getByRevision(0xc000a72ae0, {0x1c01498, 0xc00051bbc0}, {0xc000cbb1a0, 0x2a})
	/workspace/pkg/controllers/utils/poddecoration/getter.go:163 +0x219
kusionstack.io/kuperator/pkg/controllers/utils/poddecoration.(*namespacedPodDecorationManager).GetByRevisions(0xc000a72ae0, {0x1c01498, 0xc00051bbc0}, {0xc000914070, 0x1, 0x289c360?})
	/workspace/pkg/controllers/utils/poddecoration/getter.go:96 +0x185
kusionstack.io/kuperator/pkg/controllers/collaset/synccontrol.(*RealSyncControl).Scale.func1.2(0xc000b9cc00)
	/workspace/pkg/controllers/collaset/synccontrol/sync_control.go:389 +0x79e
kusionstack.io/kuperator/pkg/controllers/collaset/utils.NewPodFrom({0x1c119d8, 0xc000a6e580}, 0xc000c71ae0, 0xc000447600, {0xc000a3de78, 0x1, 0x197732d?})
	/workspace/pkg/controllers/collaset/utils/pod.go:90 +0x2ee
kusionstack.io/kuperator/pkg/controllers/collaset/synccontrol.(*RealSyncControl).Scale.func1(0xc0007d9ce0?, {0xc0003dad80?, 0xc00029c5a0?})
	/workspace/pkg/controllers/collaset/synccontrol/sync_control.go:358 +0x31d
kusionstack.io/kuperator/pkg/controllers/utils.SlowStartBatch.func1(0xc000c20fb8?)
	/workspace/pkg/controllers/utils/slow_start.go:57 +0x74
created by kusionstack.io/kuperator/pkg/controllers/utils.SlowStartBatch
	/workspace/pkg/controllers/utils/slow_start.go:55 +0x1dc

@Eikykun Eikykun requested a review from ColdsteelRail December 2, 2024 06:03
Copy link
Member

@ColdsteelRail ColdsteelRail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ColdsteelRail ColdsteelRail merged commit 70ed38b into KusionStack:main Dec 2, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants