Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(helpers): reorganize grpc target service #14045

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

gszr
Copy link
Member

@gszr gszr commented Dec 23, 2024

Summary

This PR accomplishes a few things related to gRPC testing:

  • Reorganize the mock targetservice service we use in some gRPC tests
  • Add a Makefile and simplify Lua helpers to build the code
  • Add a new EchoHeaders grpc RPC, to be used in tests that need to verify headers sent by Kong to the gRPC upstream (similar to httpbin's /anything)
  • Use the new RPC in :authority pseudo-header tests

@gszr gszr requested a review from brentos December 23, 2024 16:50
@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Dec 23, 2024
@gszr gszr force-pushed the refactor/add-echo-headrs-rpc branch from 6aa8f6c to 2b3dcff Compare December 23, 2024 16:53
@gszr gszr force-pushed the refactor/add-echo-headrs-rpc branch from 2b3dcff to 96dee67 Compare January 17, 2025 11:19
@gszr gszr changed the base branch from fix/grpc-web-and-gateway-trailers to master January 17, 2025 11:19
@gszr gszr force-pushed the refactor/add-echo-headrs-rpc branch 3 times, most recently from 28c71c1 to 6ff7e9d Compare January 22, 2025 13:33
gszr added 4 commits January 22, 2025 11:09
Add a makefile to grpc target service and simplify test helper.
This will improve testability and reliability of some gRPC tests.
Replace template-based mock grpc service with actual gRPC service to
test for `:authority` headers.
@gszr gszr force-pushed the refactor/add-echo-headrs-rpc branch from 6ff7e9d to 470db20 Compare January 22, 2025 14:09
@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Jan 22, 2025
@gszr gszr force-pushed the refactor/add-echo-headrs-rpc branch 2 times, most recently from 8de7dbf to 697b918 Compare January 22, 2025 19:14
@gszr gszr force-pushed the refactor/add-echo-headrs-rpc branch from 697b918 to 0ad5025 Compare January 22, 2025 21:21
@gszr gszr marked this pull request as draft January 22, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed size/L skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant