-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(helpers): reorganize grpc target service #14045
Draft
gszr
wants to merge
6
commits into
master
Choose a base branch
from
refactor/add-echo-headrs-rpc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
label
Dec 23, 2024
gszr
force-pushed
the
refactor/add-echo-headrs-rpc
branch
from
December 23, 2024 16:53
6aa8f6c
to
2b3dcff
Compare
gszr
force-pushed
the
refactor/add-echo-headrs-rpc
branch
from
January 17, 2025 11:19
2b3dcff
to
96dee67
Compare
gszr
changed the base branch from
fix/grpc-web-and-gateway-trailers
to
master
January 17, 2025 11:19
gszr
force-pushed
the
refactor/add-echo-headrs-rpc
branch
3 times, most recently
from
January 22, 2025 13:33
28c71c1
to
6ff7e9d
Compare
Add a makefile to grpc target service and simplify test helper.
This will improve testability and reliability of some gRPC tests.
Replace template-based mock grpc service with actual gRPC service to test for `:authority` headers.
gszr
force-pushed
the
refactor/add-echo-headrs-rpc
branch
from
January 22, 2025 14:09
6ff7e9d
to
470db20
Compare
github-actions
bot
added
the
chore
Not part of the core functionality of kong, but still needed
label
Jan 22, 2025
gszr
force-pushed
the
refactor/add-echo-headrs-rpc
branch
2 times, most recently
from
January 22, 2025 19:14
8de7dbf
to
697b918
Compare
gszr
force-pushed
the
refactor/add-echo-headrs-rpc
branch
from
January 22, 2025 21:21
697b918
to
0ad5025
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
chore
Not part of the core functionality of kong, but still needed
size/L
skip-changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR accomplishes a few things related to gRPC testing:
targetservice
service we use in some gRPC testsEchoHeaders
grpc RPC, to be used in tests that need to verify headers sent by Kong to the gRPC upstream (similar to httpbin's/anything
):authority
pseudo-header tests