fix(kgo): drop ValidationAdmissionPolicy validating DataPlanes #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
fix/remove-kgo-vap
branch
from
a852223 to
caff555
Compare
pmalek
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
ValidationAdmissionPolicy we added for validating DataPlanes wasn't tested enough and it turns out it prevents Gateway-deployed DataPlanes from being created. As a stop-gap, we're removing the VAP. KGO 1.4 users should not be affected as the VAP functionality overlaps with the admission webhook functionality that's going to be removed in 1.5.
VAP will be added back to the chart before releasing KGO 1.5.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
mainbranch.