Fix line breaks characters breaking syslog messages #9881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it would be better to trim |
|
Ah, wanted to do the change in GitHub UI. Lesson learned. I'll close this one and open proper with the fix in utils.ts. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This simple change removes \r & \n characters from the commit hash. I don't know how they ended there but this makes sure that even if they do, they are removed before logging.
Before the change:
After the change:
This would cause some syslog servers freak out and treat all logs as one message.
Previously added as a PR to master branch, please excuse my mistake.
Possible relation to #9872