Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Refactor GlyphMetrics to readonly record #820

Conversation

map-b
Copy link
Contributor

@map-b map-b commented Nov 24, 2023

Description:

To allow this pull request to be merged, please make sure that the following items of this pull request are complete.

This pull request closes #803

✅The pull request head branch must be a feature branch with the syntax 'feature/-sync-testing'.
✅The pull request base branch must be a 'main' or 'preview' branch..
✅The pull request head branch contains a valid issue number.
✅The pull request title matches the linked issue title exactly.
✅The pull request assignees match the assignees of the issue.
✅The pull request labels match the labels of the issue.
✅The pull request organizational projects match the organizational projects of the issue.
✅The pull requests milestone matches the milestone of the issue.


Additional Info:

  1. Pull requests are automatically synced with the associated issue upon creation by one of the KinsonDigital workflow bots.
  2. The associated issue is the issue number that is embedded in the pull request head branch.
  3. The list above will be automatically updated as the pull request's various settings match or do not match the associated issue.
  4. To manually sync the pull request to the issue, create a comment with the [run-sync] command.

    Note You must be an admin member of the organization to use this command.


  • Sync with the issue. Use this to enable or disable this pull request from syncing with its associated issue.

@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.31 milestone Nov 24, 2023
@CalvinWilkinson CalvinWilkinson changed the title Feature/803 refactor glyphmetrics to readonly record 🚧Refactor GlyphMetrics to readonly record Nov 24, 2023
@CalvinWilkinson CalvinWilkinson added tech-debt Code refactoring or cleanup / tech debt reduction medium-priority Medium Priority preview Done while in preview 🧨breaking-changes Feature/changes contains breaking changes 🏎️performance Performance improvements labels Nov 24, 2023
@map-b map-b marked this pull request as ready for review November 26, 2023 19:03
@CalvinWilkinson
Copy link
Member

@map-b Approved and merged!!

Awesome work map and I appreciate the collaboration. 😀

@CalvinWilkinson CalvinWilkinson merged commit 1690172 into KinsonDigital:preview Nov 27, 2023
15 checks passed
@CalvinWilkinson
Copy link
Member

Warning

Introduced the following https://github.com/KinsonDigital/Velaptor/labels/%F0%9F%A7%A8breaking%20changes

  1. Refactored the GlyphMetrics struct to a readonly record struct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧨breaking-changes Feature/changes contains breaking changes medium-priority Medium Priority 🏎️performance Performance improvements preview Done while in preview tech-debt Code refactoring or cleanup / tech debt reduction
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🚧Refactor GlyphMetrics to readonly record
2 participants