Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Bug not finding native libs #374

Merged
merged 23 commits into from
Jan 27, 2025
Merged

Conversation

CalvinWilkinson
Copy link
Member

@CalvinWilkinson CalvinWilkinson commented Jan 22, 2025

Description:

To allow this pull request to be merged, please make sure that the following items of this pull request are complete.

This pull request closes #373

✅The pull request head branch must be a feature branch with the syntax 'feature/-sync-testing'.
✅The pull request base branch must be a 'main' or 'preview' branch..
✅The pull request head branch contains a valid issue number.
✅The pull request title matches the linked issue title exactly.
✅The pull request assignees match the assignees of the issue.
✅The pull request labels match the labels of the issue.
✅The pull request organizational projects match the organizational projects of the issue.
✅The pull requests milestone matches the milestone of the issue.


Additional Info:

  1. Pull requests are automatically synced with the associated issue upon creation by one of the KinsonDigital workflow bots.
  2. The associated issue is the issue number that is embedded in the pull request head branch.
  3. The list above will be automatically updated as the pull request's various settings match or do not match the associated issue.
  4. To manually sync the pull request to the issue, create a comment with the [run-sync] command.

    Note You must be an admin member of the organization to use this command.


  • Sync with the issue. Use this to enable or disable this pull request from syncing with its associated issue.

@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.21 milestone Jan 22, 2025
@CalvinWilkinson CalvinWilkinson changed the title new pr 🚧Bug not finding native libs Jan 22, 2025
@CalvinWilkinson CalvinWilkinson added 🐛bug Something isn't working high-priority High Priority preview Done while in preview labels Jan 22, 2025
@CalvinWilkinson CalvinWilkinson self-assigned this Jan 22, 2025
@CalvinWilkinson
Copy link
Member Author

Note

Changed how the open al native audio library is handled to accommodate self-contained and single-file builds.
First, the platform-specific library is checked in the same directory as the CASL binary. If it exists, then it will be used.
If it does not exist, it is assumed that we are running in a standard build environment for development and the library exists
in the native platform directory. If it does not exist, then an exception is thrown; otherwise, the native library is copied to
the CASL binary location and then loaded as usual.

@CalvinWilkinson
Copy link
Member Author

Warning

Introduced the following breaking changes:

  1. Removed support for 32bit (x86) builds of the library.

@CalvinWilkinson CalvinWilkinson force-pushed the feature/373-not-finding-libs branch from 15d1b6b to 1392b9c Compare January 27, 2025 19:00
@CalvinWilkinson CalvinWilkinson added the 🧨breaking-changes Feature/changes contains breaking changes label Jan 27, 2025
@CalvinWilkinson CalvinWilkinson marked this pull request as ready for review January 27, 2025 22:09
@CalvinWilkinson CalvinWilkinson merged commit 1c51537 into preview Jan 27, 2025
10 checks passed
@CalvinWilkinson CalvinWilkinson deleted the feature/373-not-finding-libs branch January 27, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧨breaking-changes Feature/changes contains breaking changes 🐛bug Something isn't working high-priority High Priority preview Done while in preview
Projects
Status: ✅Done
Development

Successfully merging this pull request may close these issues.

🚧Bug not finding native libs
2 participants