Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SubmittingModels.md
may have to be reviewed.Things that are fixed in the current state of this PR:
#converters
. Minor rewording of the variants. Added requirement that models pass validation (!)metadata.json
Here, I stumbled: The description of the JSON there is a bit incomplete, and I'm not sure how to complete this:
version: 2
? (I wondered whether this referred to glTF itself...).tags
? (Yeah, 🐘 -> 🏠 )name
: The name of the subdirectory that the model is contained inpath
: The path of the model subdirectory, relative to the repository rootscreenshot
: The path to the screenshot, relative to the model subdirectorysummary
: A short description of what the model is or demonstratescreateReadme
: Should always betrue
The
legal
part also does not seem to list everything that can be found in the actual JSON files. One example isThat looks like a lot of redundant redundancy, which is pretty redundant.
license
andspdx
? Iflicense
is only intended for non-spdx licenses, then I wonder whether this could be merged intolicense
, with the values either being one of the spdx-identifiers, or"Custom"
.text
really only for the link text, and does it make a difference of whether the link text is CC-BY 4.0 or CC-BY 4.0 International ?icon
link... hm. Is this necessary and useful? Even if the answer is 'yes': Is "hotlinking" to a random PNG file the right thing to do here...?And... most importantly: What exactly do submitters have to do here? Which of these fields are (or can be) auto-filled: I've seen that link to the
CreateJson.html
(which of course does not work on GitHub...), but is this supposed to fill out most of this information based on less input? Users shouldn't have to figure out thelicenseUrl
on their own, and it would be hard to make sure that the information in the given form is consistent ...