-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable C++ 20 standard globally #1257
base: main
Are you sure you want to change the base?
Conversation
Old style no longer worked due to C++20 compile time requirements
Once we merge this, I think we can remove one or two external dependencies (submodules). Right now. printing formatted messages (e.g. errors) is knda complicated and goes through our framework and two externeal dependencies. One of those is "fmt", and it seems that it's functionality is also present in the STL with C++20. So we could get rid of "fmt" and maybe also "spdlog". I don't think we need to have such a complicated setup just for logging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A
@jackk18912525: Can you please remove your spam comment and also remove yourself from the reviewers? |
A blocker is the HCWPipe third party dependency. I can't get it to compile after updating to C++20, and updating the submodule doesn't help either (esp.a s the library is now differently named). I need help on this from someone from arm, maybe @JoseEmilio-ARM? |
Description
Note: This is work-in-progress and not ready for review yet. I didn't set it to "draft", as I wanted to test CI to see where things break with C++ 20.
Refs #1201
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batch
command line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: