Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the CullPrimitiveEXT VUID's #2475

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix the CullPrimitiveEXT VUID's #2475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions chapters/interfaces.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2249,11 +2249,13 @@ culled, if it is code:false it will not be culled.
The variable decorated with code:CullPrimitiveEXT must: be declared
using the code:Output {StorageClass}
* [[VUID-{refpage}-CullPrimitiveEXT-07036]]
The variable decorated with code:CullPrimitiveEXT must: be declared as
an array of boolean values
* [[VUID-{refpage}-CullPrimitiveEXT-07037]]
The size of the array decorated with code:CullPrimitiveEXT must: match
the value specified by code:OutputPrimitivesEXT
code:CullPrimitiveEXT must: be declared as a boolean value member of a structure or a variable of type code:OpTypeArray of boolean values.
* If code:CullPrimitiveEXT declared as an array of boolean values. The size of the array
decorated with code:CullPrimitiveEXT must: match the value specified by code:OutputPrimitivesEXT
* If code:CullPrimitiveEXT is a member of a structure, there must: be a variable declared
which is array of parent strucure that contains code:CullPrimitiveEXT. The size of the array must: match the value specified by code:OutputPrimitivesEXT.
* There must be only one declaration of the code:CullPrimitiveEXT associated with a entry
point's interface.
Comment on lines +2252 to +2258
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
code:CullPrimitiveEXT must: be declared as a boolean value member of a structure or a variable of type code:OpTypeArray of boolean values.
* If code:CullPrimitiveEXT declared as an array of boolean values. The size of the array
decorated with code:CullPrimitiveEXT must: match the value specified by code:OutputPrimitivesEXT
* If code:CullPrimitiveEXT is a member of a structure, there must: be a variable declared
which is array of parent strucure that contains code:CullPrimitiveEXT. The size of the array must: match the value specified by code:OutputPrimitivesEXT.
* There must be only one declaration of the code:CullPrimitiveEXT associated with a entry
point's interface.
code:CullPrimitiveEXT must: decorate a scalar boolean member of a structure decorated as code:Block, or decorate a variable of type code:OpTypeArray of boolean values.
* If code:CullPrimitiveEXT is declared as an array of boolean values, the size of the array
must: match the value specified by code:OutputPrimitivesEXT
* If code:CullPrimitiveEXT decorates a member of a structure, the variable declaration of the containing code:Block type must: have an array size that matches the value specified by code:OutputPrimitivesEXT
* There must be only one declaration of the code:CullPrimitiveEXT associated with a entry
point's interface.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this language reads closer to the rest of the spec, but otherwise, the gist of it is fine.

* [[VUID-{refpage}-CullPrimitiveEXT-07038]]
The variable decorated with code:CullPrimitiveEXT within the
code:MeshEXT {ExecutionModel} must: also be decorated with the
Expand Down
Loading