Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider for chromium based edge bookmarks #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dozius
Copy link

@dozius dozius commented Jan 14, 2021

This adds a provider to the bookmarks package for the chromium based Microsoft Edge browser.

@lgoose
Copy link

lgoose commented Jun 20, 2021

Is this something I can install/update myself? I see the 3 files changed and could update the config file, but I �don't know where to find the other two files to be updated

@sam97
Copy link
Contributor

sam97 commented Jun 23, 2021

@lgoose You can install it as a Live Package. Just copy the Bookmarks folder from this branch to the Packages directory and it will override your installed package.

Do remember to remove the live package once this PR has been merged and you've downloaded the latest version of KP. Otherwise any future updates will keep getting overriden by your live package.

Also, if you face any issues with the package keep in mind to reproduce them by removing the live package. Mention the live package if you're posting an issue.

@PolarGoose
Copy link

PolarGoose commented Oct 31, 2021

It is a pity this pull request has not been merged yet.

Let me provide a detailed instruction of how to use these changes (based on the comment from @sam97)

  1. Download the changed Bookmarks plugin: https://github.com/dozius/Packages/archive/bookmarks-chromium-edge-provider.zip
  2. Copy Packages-bookmarks-chromium-edge-provider\Bookmarks directory from the downloaded zip archive to %AppData%\Keypirinha\Packages or if you use a portable version to Keypirinha\portable\Profile\Packages
  3. Right click on the Keypirinha tray icon->"Configure package"->Bookmarks. You should see 3 files as it is shown on the screenshot. It means that Keypirinha has detected the modified Bookmarks and will use it instead of the default one.
    image
  4. Update the catalog: Right click on the Keypirinha tray icon->"Refresh catalog"->Bookmarks

@Oroumov
Copy link

Oroumov commented Feb 4, 2022

Hi @PolarGoose
Thanks for the detailed instructions.
Probably a dumb question, but somehow I'm unable to connect them with what my portable installation looks like.
I don't have anything in %AppData% of course, but also I don't see a similar looking structure anywhere, with an existing "providers" folder or anything that looks remotely like it.
Do you know if I've missed something obvious or should it be placed in a different location?
Thanks !

@PolarGoose
Copy link

@Oroumov ,
I have updated my previous comment to take into account the portable version of Keypirinha. Is it clear now what needs to be done?

@Oroumov
Copy link

Oroumov commented Feb 9, 2022

It was very helpful ! I had nothing in the Keypirinha\portable\Profile\Packages section, so it wasn't obvious at all (especially given the number of Packages folders in the tree of the portable version).

Everything is working just fine now, thanks !!

Final thought : for the sake of clarity (although it was obvious for me after customising other packages), you might want to add also that you need to enable a [provider/Edge] section in the bottom right .ini file for everything to be operational :) this might help beginners to understand it completely.

@PolarGoose
Copy link

you might want to add also that you need to enable a [provider/Edge] section in the bottom right .ini file for everything to be operational

It is not necessary. All bookmarks plugins are enabled by default, including the Edge one.

@Oroumov
Copy link

Oroumov commented Feb 10, 2022

My lack of knowledge is showing again :) Thanks for all your help !

@JeffMill
Copy link

JeffMill commented Oct 26, 2023

I was able to get this to work without any code change.

Choose Keypirinha: Configure Package: Url

Then in user settings, place:

[provider/Chrome]
enable = yes
bookmarks_files = ${var:KNOWNFOLDER_LOCALAPPDATA}\Microsoft\Edge\User Data\Default\Bookmarks

Edge bookmarks should now show up, at least they did for me.

@PolarGoose
Copy link

I was able to get this to work without any code change.

Choose Keypirinha: Configure Package: Url

Then in user settings, place:

[provider/Chrome]
enable = yes
bookmarks_files = ${var:KNOWNFOLDER_LOCALAPPDATA}\Microsoft\Edge\User Data\Default\Bookmarks

Edge bookmarks should now up, at least they did for me.

It works perfectly. Thank you for sharing.

@tobimau
Copy link

tobimau commented Jul 31, 2024

I was able to get this to work without any code change.

Choose Keypirinha: Configure Package: Url

Then in user settings, place:

[provider/Chrome]
enable = yes
bookmarks_files = ${var:KNOWNFOLDER_LOCALAPPDATA}\Microsoft\Edge\User Data\Default\Bookmarks

Edge bookmarks should now up, at least they did for me.

Little correction: I needed to choose Keypirinha: Configure Package: Bookmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants