JS best practices

[Kel-nana]

JS best practices

• Keep all the JavaScript code in JS-files, not in the script tag.

• Keep your code clean following this advice about:

• type checks.

• naming.

• simplicity.

• DRY.

• Live Demo

[ab-noori]

Hi @Kel-nana ,

Good job so far!
There are some small issues, although they are not the requirements for this activity I think it is good practice to follow them. but you are almost there!

Highlights

• JavaScript best practices 👍
• DRY, KISS, and YAGNI rules 👍
• HTML & CSS best practices 👍
• Linter set up well and checks pass 🟢
• Branch name is descriptive 💯
• GitHub flow followed 👌
• .gitignore used to ignore unnecessary files 📁
• Commit messages are meaningful 📝
• PR description is descriptive 📝

Required Changes ♻️

• [REQUIRED] It is good to keep all your modules inside your modules directory, I noticed that some of your modules are in SRC root. Just keep index files in the SRC root. 👇

• [OPTIONAL] Go to your repository in the right corner you will find a sitting icon. from there you can add:

  • A short description of your project as it exists in your readme file.
  • The demo link of your project as it exists in your readme file.
  • Some topic labels.

👉------------------------------------------------------------------------------------------👇

[Kel-nana]

Changes Implementation

• Move all files to src/modules apart from index.js implemented .
• Addition of short description
  IMAGE
  

[ab-noori]

Status: Approved ✔️

Hi @Kel-nana, 👋

Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉

Highlights

• Amazing work you have done so far 👍
• Great implementation of all the requirements requested in the previous review ✔

Cheers and Happy coding!👏👏👏