Fixes #38206 - make token endpoint work concurrently #11306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qcjames53
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
I was able to verify that this PR allows for any number of users to request OCI auth at the exact same time. Users are still rejected as normal when improper credentials are supplied. The source looks good to me and I don't think any unit test changes are needed. ACKing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Adds retry and transaction logic to ensure that two concurrent clients won't trigger a database race condition.
Considerations taken when implementing this change?
Is the transaction necessary?
What are the testing steps for this pull request?
PersonalAccessTokenrecords called 'registry'.-w 1).personal_token.save!on line 489.podman loginon two separate terminals at the same time.These reproducer steps simulate any number of hosts that might be trying to log in at the same time.