Fixes #38196 - Remove use of $.removeAttr from Katello #11304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjha4
reviewed
Feb 11, 2025
app/assets/javascripts/katello/widgets/env_content_view_selector.js
Outdated
Show resolved
Hide resolved
sjha4
reviewed
Feb 11, 2025
sjha4
reviewed
Feb 11, 2025
jeremylenz
force-pushed
the
38196-no-removeattr
branch
from
b0d3b62 to
e82fa52
Compare
|
@sjha4 Restored those 3 files. 👍 |
sjha4
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Won't experiment with other files here..Some are dead code, the files in 'app/assets/javascripts/katello/widgets/' for example..Deleting others caused weirdness in my console although the UI seemed to be working alright. Fine to leave them alone with the jquery fix.
Ack 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Because of this breaking change in jQuery 3.0, the 'Select None' button on the Sync Status page had stopped working. This change should make it work again.
Considerations taken when implementing this change?
The solution is to replace
removeAttr()with.prop(attrName, value). I found several other instances of its use, which I also updated. There were a few where I'm not surefalseis the correct value, but I don't know if that will matter..What are the testing steps for this pull request?
Reproduce the issue:
Make sure your Foreman is up to date with latest develop and Katello is latest master
Run npm i
Fix the issue:
Check out this PR
check Sync Status page Select None button, make sure it works
Check other Angular pages and make sure I didn't break anything