Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36829 - supprimer used incorrectly in French translations #10839

Merged

Conversation

ianballou
Copy link
Member

What are the changes introduced in this pull request?

Updates all translations to be up-to-date with Transifex. Also fixes the wrong translations noted in https://projects.theforeman.org/issues/36829 and https://projects.theforeman.org/issues/36945

Considerations taken when implementing this change?

...

What are the testing steps for this pull request?

  1. Switch to French
  2. Check that the "Create Activation Key" button says "Creer une cle d'activation" (with accent marks)
  3. Check that the "Create Product" button says "Creer un produit" (with accent marks)

@ianballou ianballou force-pushed the 36829-fix-some-french-translations branch from 42f48b7 to 6c1fec8 Compare January 9, 2024 20:56
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub UI does not like this PR. It may be worth looking at the translation files and look at their percentages. If they're below a certain number, perhaps drop them?

For now I'd merge this though.

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ianballou
Copy link
Member Author

The GitHub UI does not like this PR. It may be worth looking at the translation files and look at their percentages. If they're below a certain number, perhaps drop them?

I agree, no sense really keeping anything that isn't well-translated. Hmm maybe 50% ?

@ianballou ianballou merged commit ae7ee10 into Katello:master Jan 11, 2024
5 checks passed
@ianballou ianballou deleted the 36829-fix-some-french-translations branch January 11, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants