Fixes #37084 - Drop simplecov dependency #10837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No one from Katello that I know of uses them. I would be fine dropping it entirely. @ianballou ? |
|
I'm cool with dropping it, I don't think the reports are used. |
This is a test dependency, but marked as a development dependency. We currently install all development dependencies while testing katello, but don't do that for any other plugin. This is an effort to reduce the development dependencies to pure development dependencies.
|
Now with a Redmine issue. |
ekohl
changed the title
parthaa
approved these changes
Jan 24, 2024
ekohl
added a commit
to ekohl/katello
that referenced
this pull request
Apr 19, 2024
This is a test dependency, but marked as a development dependency. We currently install all development dependencies while testing katello, but don't do that for any other plugin. This is an effort to reduce the development dependencies to pure development dependencies. (cherry picked from commit 2ab734f)
chris1984
pushed a commit
that referenced
this pull request
Apr 19, 2024
This is a test dependency, but marked as a development dependency. We currently install all development dependencies while testing katello, but don't do that for any other plugin. This is an effort to reduce the development dependencies to pure development dependencies. (cherry picked from commit 2ab734f)
m-bucher
pushed a commit
to ATIX-AG/katello
that referenced
this pull request
Jun 21, 2024
This is a test dependency, but marked as a development dependency. We currently install all development dependencies while testing katello, but don't do that for any other plugin. This is an effort to reduce the development dependencies to pure development dependencies. (cherry picked from commit 2ab734f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
This is a test dependency, but marked as a development dependency. We currently install all development dependencies while testing katello, but don't do that for any other plugin. This is an effort to reduce the development dependencies to pure development dependencies.
Considerations taken when implementing this change?
We may want this, but then we need to figure that out. Currently this is marked as a draft because it's only up for discussion now.
One option is to rescue
LoadErrorif it's unavailable and gracefully deal with it.Big question is: does anyone use these coverage reports?