Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Filters next to the Product List #82

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Move Filters next to the Product List #82

merged 3 commits into from
Jan 10, 2025

Conversation

gadyrcdz
Copy link
Contributor

@gadyrcdz gadyrcdz commented Jan 10, 2025 •
edited
Loading

📝 Pull Request Title

  • Refactor: Move SidebarComponent to Filters Component in Marketplace Directory

🛠️ Issue

📖 Description

  • This PR moves the existing SidebarComponent from the marketplace page to a new filter file.tsx inside the components/marketplace directory. The component is renamed to Filters. The layout has been adjusted to ensure the filters appear next to the product list while maintaining full functionality and responsiveness.

✅ Changes made

  • Moved SidebarComponent to components/marketplace/filters.tsx.
  • Renamed SidebarComponent to Filters.
  • Updated the layout to display filters next to the product list.
  • Ensured that the component remains fully functional after relocation.
  • Verified that the design is responsive and visually cohesive with the existing Marketplace interface.

🖼️ Media (screenshots/videos)

  • Category Filter
    image
  • Price Range Filter
    image

📜 Additional Notes

  • No major styling changes were made, but minor adjustments were implemented to maintain visual consistency.

@derianrddev derianrddev self-requested a review January 10, 2025 03:43
derianrddev
derianrddev requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@derianrddev derianrddev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gadyrcdz Nice job! Just some minor changes.

frontend/app/marketplace/page.tsx Outdated Show resolved Hide resolved
frontend/app/layout.tsx Outdated Show resolved Hide resolved
@derianrddev derianrddev requested a review from danielcdz January 10, 2025 04:15
@danielcdz danielcdz changed the title Fix #50 Move Filters next to the Product List Jan 10, 2025
@danielcdz
Copy link
Member

LGTM

@danielcdz danielcdz merged commit 323b66c into KaizeNodeLabs:main Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derianrddev derianrddev derianrddev approved these changes

@danielcdz danielcdz danielcdz approved these changes

Assignees

@gadyrcdz gadyrcdz

Labels
actual: 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Filters next to the Product List
3 participants
@gadyrcdz @danielcdz @derianrddev