Issue #132: Added Module for Product Images #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derianrddev
requested changes
Feb 11, 2025
apps/backend/src/modules/product-image/dto/productimage.input.ts
Outdated
Show resolved
Hide resolved
apps/backend/src/modules/product-image/entities/productimage.entity.ts
Outdated
Show resolved
Hide resolved
derianrddev
reviewed
Feb 11, 2025
apps/backend/src/modules/product-image/product-image.resolver.ts
Outdated
Show resolved
Hide resolved
derianrddev
reviewed
Feb 11, 2025
apps/backend/src/modules/product-image/product-image.resolver.ts
Outdated
Show resolved
Hide resolved
|
@Shukazuby Could you please share a screenshot of GraphQL queries for ProductImage, similar to this one? It can be with any test data, I just need an example that includes fetching all product images and a specific product image by ID. |
|
@Shukazuby Once you finish, please run
|
derianrddev
requested changes
Feb 11, 2025
There was a problem hiding this comment.
@Shukazuby It looks like a change hasn’t been addressed yet. Please make sure to resolve it and add the migration, please.
derianrddev
reviewed
Feb 11, 2025
derianrddev
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
@Shukazuby Thank you for making the changes. LGTM! Great job!🚀Let’s wait for a second review. @danielcdz
danielcdz
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #132: Added Module for Product Images
Closes #132
Added Service, Resolver and Module to add, fetch all, and fetch product images by Id.
To help with the task, I created a provisional product module to create product, reference it to product image and tested with created product id.