-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add product filters #141
Feature/add product filters #141
Conversation
…ilters arrays and neccesary imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nomolos29, Just a couple of tweaks:
-
The filters are currently not aligned with the Breadcrumbs Navigation. Could you adjust them to align properly?
-
Please uninstall
react-icons
and replace it with theFilter
icon fromlucide-react
. -
The checkbox is not visible in dark mode. Could you adjust the styles to make it more visible?
-
If the
Toast
component fromshadcn/ui
is not being used, please remove it.
I like how the filters are implemented for mobile screens. Nice job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nomolos29 Thank you for making the changes. LGTM! 🚀Let’s wait for a second review. @danielcdz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! I see it now.
I did not understand the comment earlier, sorry about that.
@Nomolos29 No problem! It was mostly to avoid a linter error, since 'Select Filter' is an interactive element that triggers an action when the user clicks it. |
📝 Pull Request Title
feat: Add reusable filter component with categories and price range filters
🛠️ Issue
📖 Description
This PR introduces a reusable filter component for the marketplace product page. The filter allows users to:
The filter component is fully responsive and accessible, ensuring a seamless user experience across all devices.
✅ Changes made
🖼️ Media (screenshots/videos)
**Filter Co
![DestopView1](https://private-user-images.githubusercontent.com/86138279/411743805-a41564f6-dd14-4f8b-8cdb-c664d6b2ce03.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NzU5NDYsIm5iZiI6MTczOTU3NTY0NiwicGF0aCI6Ii84NjEzODI3OS80MTE3NDM4MDUtYTQxNTY0ZjYtZGQxNC00ZjhiLThjZGItYzY2NGQ2YjJjZTAzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDIzMjcyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZlNDZlOGJiN2Y1YjcxZTYyMDc1MTBkNDg5NjMwYjNkM2VjMjFiMWI0NDM5MTA1ZTM3ZDgyYzFiZWY5MDRiNDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.4yX__pzaE9m1mLSaHkCqtaGG6f3oHsUZNwfLHaVroqQ)
![DestopView2](https://private-user-images.githubusercontent.com/86138279/411743821-32d823e0-b9ae-4ea5-a9cc-c7a7e068ac41.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NzU5NDYsIm5iZiI6MTczOTU3NTY0NiwicGF0aCI6Ii84NjEzODI3OS80MTE3NDM4MjEtMzJkODIzZTAtYjlhZS00ZWE1LWE5Y2MtYzdhN2UwNjhhYzQxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDIzMjcyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTIxY2U1YzY5ODIxMjBiOTk1Zjk0MWVhMTdiYWE0ZGRhNDdkODY4YmFjYTk5NTliNDAzNzY4OTkwMGZlMmU1MDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Arv4I1ZMEqfi8r_cysJKF00C24dKcO25ggk6i_IoCJU)
![DestopView3](https://private-user-images.githubusercontent.com/86138279/411743837-cb539cd1-4f23-44a0-9ee5-1d04b03448ae.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NzU5NDYsIm5iZiI6MTczOTU3NTY0NiwicGF0aCI6Ii84NjEzODI3OS80MTE3NDM4MzctY2I1MzljZDEtNGYyMy00NGEwLTllZTUtMWQwNGIwMzQ0OGFlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDIzMjcyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU5MmJhNjhjYTZiNWYwNzAwNTY3ZmEzNWM1YjAyMDE5NjdhZWI5NmRhOGU4MTJhNzhiYWM0MTYzNmRiZGRlOTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.cW1nzd4Y25odI_izXDBKF1GnynO7zNXB6N3UTmQXiXg)
Responsive Design:
![mobileView png2](https://private-user-images.githubusercontent.com/86138279/411744395-fcf2253f-e6ad-45fe-a5c1-3a7243a80476.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NzU5NDYsIm5iZiI6MTczOTU3NTY0NiwicGF0aCI6Ii84NjEzODI3OS80MTE3NDQzOTUtZmNmMjI1M2YtZTZhZC00NWZlLWE1YzEtM2E3MjQzYTgwNDc2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDIzMjcyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZhZTkxNTllMzEyNWFkYmU2ZDMwYTE3ZmZjMjRiZWM5YTlhZDY1MWU2ZDZiMmU4ODY4ZDgwYTViMmNiZTQxMGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.f8c_I7NBSbWd5qCbNuECCt4Qn3Fq3vgWoVDJbz9xjn4)
![mobileView png3](https://private-user-images.githubusercontent.com/86138279/411744404-f9aac165-1669-4765-8e4b-51cb0644f218.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NzU5NDYsIm5iZiI6MTczOTU3NTY0NiwicGF0aCI6Ii84NjEzODI3OS80MTE3NDQ0MDQtZjlhYWMxNjUtMTY2OS00NzY1LThlNGItNTFjYjA2NDRmMjE4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDIzMjcyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRiODU5NzViMzgzMWRkODdiMGJjYzVjMzRkMmU3NmFiNzJlZjY0MzRiZTViNTJjMTdkOWUwMjkzMDY2ODE2NWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.PrqsGjLLofLbFDm7LO8WXgA-aa5er09J9wGb1uv3F0Q)
![mobileView1](https://private-user-images.githubusercontent.com/86138279/411744410-d56bc59a-39bb-4165-b640-bd46d6ef6d25.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NzU5NDYsIm5iZiI6MTczOTU3NTY0NiwicGF0aCI6Ii84NjEzODI3OS80MTE3NDQ0MTAtZDU2YmM1OWEtMzliYi00MTY1LWI2NDAtYmQ0NmQ2ZWY2ZDI1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDIzMjcyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgxYzlmNjE4ZjFmMTJjM2ExMThkNjE3Njg0MmI2N2E5NTdjNTg2M2QxNTIwZTQxNjg2MjUxZmU4YjkxOTYxMDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.gaODCxTqLAIAuZc5Vq3hyPZHHHjm9nYH4m_5r-L1cr0)
📜 Additional Notes