Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add product filters #141

Merged
merged 13 commits into from
Feb 11, 2025

Conversation

Nomolos29
Copy link
Contributor

@Nomolos29 Nomolos29 commented Feb 10, 2025

📝 Pull Request Title

feat: Add reusable filter component with categories and price range filters

🛠️ Issue

📖 Description

This PR introduces a reusable filter component for the marketplace product page. The filter allows users to:

  • Select multiple categories using a searchable dropdown.
  • Filter products by predefined price ranges using checkboxes.
  • Apply or reset filters with dedicated buttons.

The filter component is fully responsive and accessible, ensuring a seamless user experience across all devices.

✅ Changes made

  • feat: Added a reusable filter component with categories and price range filters.
  • feat: Integrated the filter component with the product page.
  • feat: Implemented "Apply Filters" and "Reset" functionality.
  • style: Made the filter UI responsive and accessible.
  • fix: Installed all required dependencies.

🖼️ Media (screenshots/videos)

  • **Filter Co
    DestopView1
    DestopView2
    DestopView3

  • Responsive Design:
    mobileView png2
    mobileView png3
    mobileView1

📜 Additional Notes

  • The filter component uses shadcn/ui for consistent styling.
  • Tailwind CSS utilities were used to ensure responsiveness.
  • The filter logic is decoupled from the product page, making it reusable across the application.

@derianrddev derianrddev self-requested a review February 10, 2025 21:17
@derianrddev derianrddev added enhancement New feature or request frontend labels Feb 10, 2025
Copy link
Contributor

@derianrddev derianrddev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nomolos29, Just a couple of tweaks:

  • The filters are currently not aligned with the Breadcrumbs Navigation. Could you adjust them to align properly?

    image

  • Please uninstall react-icons and replace it with the Filter icon from lucide-react.

  • The checkbox is not visible in dark mode. Could you adjust the styles to make it more visible?

    image

  • If the Toast component from shadcn/ui is not being used, please remove it.

I like how the filters are implemented for mobile screens. Nice job!

apps/frontend/components/marketplace/ProductFilter.tsx Outdated Show resolved Hide resolved
apps/frontend/components/marketplace/ProductFilter.tsx Outdated Show resolved Hide resolved
apps/frontend/components/marketplace/ProductFilter.tsx Outdated Show resolved Hide resolved
@Nomolos29
Copy link
Contributor Author

Nomolos29 commented Feb 11, 2025

All changes has been effected.

Screenshot from 2025-02-11 01-17-11
Screenshot from 2025-02-11 01-31-10

@derianrddev derianrddev self-requested a review February 11, 2025 00:30
Copy link
Contributor

@derianrddev derianrddev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nomolos29 Thank you for making the changes. LGTM! 🚀Let’s wait for a second review. @danielcdz

Copy link
Contributor Author

@Nomolos29 Nomolos29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I see it now.

I did not understand the comment earlier, sorry about that.

@derianrddev
Copy link
Contributor

@Nomolos29 No problem! It was mostly to avoid a linter error, since 'Select Filter' is an interactive element that triggers an action when the user clicks it.

@danielcdz danielcdz merged commit 57f87ee into KaizeNodeLabs:main Feb 11, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Redesign Filters UI
3 participants