feat: create reusable NotFound component and add global 404 page; #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derianrddev
requested changes
Feb 10, 2025
derianrddev
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
@BigBen-7 Thank you for making the changes. LGTM! 🚀Let’s wait for a second review. @danielcdz
danielcdz
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Pull Request Title
🛠️ Issue
✅ Changes made
Created
components/common/not-found.tsxas a reusable NotFound component.Refactored Product Not Found page to use the new common NotFound component.
Implemented a global 404 page (
app/not-found.tsx) for handling undefined routes.Ensured all NotFound usages display appropriate messages and icons.
🖼️ Media (screenshots/videos)