Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure of certain settings to make them easier to read #49

Open
dgupta7 opened this issue Oct 3, 2022 · 0 comments
Open

Structure of certain settings to make them easier to read #49

dgupta7 opened this issue Oct 3, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dgupta7
Copy link
Collaborator

dgupta7 commented Oct 3, 2022

There are some settings like S.bounds.coordinates, S.misc.msk_geom_bounds, S.subject.muscle_strength, S.subject.muscle_pass_stiff_scale, S.subject.muscle_pass_stiff_shift, S.subject.tendon_stiff_scale, S.subject.scale_MT_params, S.subject.set_damping_coefficient_selected_dofs, S.subject.set_stiffness_coefficient_selected_dofs whose structure can be changed and made easier to use and read.
Currently these settings are cell arrays of size [1 x 3*no of settings]. For example, For example, S.subject.scale_MT_params = {{'soleus_l','soleus_r'},'FMo',0.9,{'tib_ant_l'},'lTs',1.1} will scale max isometric force of both soleus by a factor of 0.9 and tendon slack length of tibialis anterior left by a scale of 1.1.
I think we should change the structure to have a size [no of settings x 3]. So for the above example,
S.subject.scale_MT_params = {{'soleus_l','soleus_r'},'FMo',0.9;...
{'tib_ant_l'},'lTs',1.1}
This way, when a reader reads the settings in the variables window, the changes appear in separate rows, rather than all lumped one after the other in the same row.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants