Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore default version support for SpaceDock #4272

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Restore default version support for SpaceDock #4272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletions Netkan/Sources/Spacedock/SpacedockMod.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,13 @@ internal class SpacedockMod
[JsonProperty] public Uri? background;

public SDVersion Latest()
{
// The version we want is specified by `default_version_id`, it's not just
// the latest. See GH #214. Thanks to @Starstrider42 for spotting this.

var latest =
from release in versions
where release.id == default_version_id
select release
;

// There should only ever be one.
return latest.First();
}
=> All().First();

public IEnumerable<SDVersion> All()
=> versions ?? Enumerable.Empty<SDVersion>();
// The version we want is specified by `default_version_id`, it's not just
// the latest. See GH #214. Thanks to @Starstrider42 for spotting this.
=> versions?.OrderByDescending(v => v.id == default_version_id)
?? Enumerable.Empty<SDVersion>();

/// <summary>
/// Returns the path to the mod's home on SpaceDock
Expand Down
Loading