Fix exception when the same module is in multiple repos #4264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
KSP-CKAN/NetKAN#10303 is throwing:
Cause
This exception indicates that
Registry.LatestAvailableWithProvides
returned multiple copies ofRSSOrigin-TopoRevampTextures16k
, which would have happened because it's present in both the default repo and the custom repo that the validator uses for the freshly inflated replacement modules. It should only return the one with the higher repo priority.Changes
HashSet
to array to preserve the priority ordering of the source reposRegistry.LatestAvailableWithProvides
callsDistinct
to filter duplicates out of its returned list