Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make X skip buttons in changelog work better for modpacks #4143

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Make X skip buttons in changelog work better for modpacks #4143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions GUI/Controls/Changeset.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ private void ChangesGrid_CellClick(object sender, DataGridViewCellEventArgs e)
&& row.Change.IsRemovable
&& row.ConfirmUncheck())
{
(ChangesGrid.DataSource as BindingList<ChangesetRow>)?.Remove(row);
changeset.Remove(row.Change);
OnRemoveItem?.Invoke(row.Change);
}
}
Expand Down
4 changes: 3 additions & 1 deletion GUI/Controls/ManageMods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -963,7 +963,9 @@ private void guiModule_PropertyChanged(object sender, PropertyChangedEventArgs e

public void RemoveChangesetItem(ModChange change)
{
if (change.IsRemovable
if (currentChangeSet != null
&& currentChangeSet.Contains(change)
&& change.IsRemovable
&& mainModList.full_list_of_mod_rows.TryGetValue(change.Mod.identifier,
out DataGridViewRow row)
&& row.Tag is GUIMod guiMod)
Expand Down