Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch wiki when Windows users select dev updates #4059

Merged
merged 1 commit into from
Mar 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Cmdline/Action/Upgrade.cs
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,12 @@ public int RunCommand(CKAN.GameInstance instance, object raw_options)
|| (!options.stable_release && (config.DevBuilds ?? false));
if (devBuild != config.DevBuilds)
{
if (!config.DevBuilds.HasValue && devBuild && Platform.IsWindows)
{
// Tell Windows users about malware scanner's false positives
// and how to disable it, if they feel safe doing it
Utilities.ProcessStartURL(HelpURLs.WindowsDevBuilds);
}
config.DevBuilds = devBuild;
user.RaiseMessage(
config.DevBuilds ?? false
Expand Down
1 change: 1 addition & 0 deletions Core/HelpURLs.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ public static class HelpURLs
public const string ModPacks = "https://github.com/KSP-CKAN/CKAN/wiki/Sharing-a-modlist-%28metapackages%29";
public const string AuthTokens = "https://github.com/KSP-CKAN/CKAN/wiki/Adding-a-GitHub-API-authtoken";
public const string CertificateErrors = "https://github.com/KSP-CKAN/CKAN/wiki/SSL-certificate-errors";
public const string WindowsDevBuilds = "https://github.com/KSP-CKAN/CKAN/wiki/Using-dev-builds-on-Windows";

public const string CloneFakeInstances = "https://github.com/KSP-CKAN/CKAN/pull/2627";
public const string DeleteDirectories = "https://github.com/KSP-CKAN/CKAN/pull/2962";
Expand Down
6 changes: 6 additions & 0 deletions GUI/Main/MainAutoUpdate.cs
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@ private void AutoUpdatePrompts(IConfiguration coreConfig,
coreConfig.DevBuilds = !YesNoDialog(Properties.Resources.MainReleasesOrDevBuildsPrompt,
Properties.Resources.MainReleasesOrDevBuildsYes,
Properties.Resources.MainReleasesOrDevBuildsNo);
if (coreConfig.DevBuilds.Value && Platform.IsWindows)
{
// Tell Windows users about malware scanner's false positives
// and how to disable it, if they feel safe doing it
Utilities.ProcessStartURL(HelpURLs.WindowsDevBuilds);
}
}
}

Expand Down
Loading