Merge #4272 Restore default version support for SpaceDock

CHANGELOG.md

@@ -32,6 +32,7 @@ All notable changes to this project will be documented in this file.
 - [Netkan] Tests for Newtonsoft.Json's handling of octal literals in version files (#4227 by: HebaruSan)
 - [Netkan] Create netkan schema (#4254, #4258 by: HebaruSan, Danny2462; reviewed: HebaruSan)
 - [Netkan] Handle raw GitHub URLs containing refs/heads/ (#4263 by: HebaruSan)
+- [Netkan] Restore default version support for SpaceDock (#4272 by: HebaruSan)
 
 ## v1.35.2 (Penrose)
 

Netkan/Sources/Spacedock/SpacedockMod.cs

@@ -20,22 +20,13 @@ internal class SpacedockMod
         [JsonProperty] public Uri?             background;
 
         public SDVersion Latest()
-        {
-            // The version we want is specified by `default_version_id`, it's not just
-            // the latest. See GH #214. Thanks to @Starstrider42 for spotting this.
-
-            var latest =
-                from release in versions
-                where release.id == default_version_id
-                select release
-            ;
-
-            // There should only ever be one.
-            return latest.First();
-        }
+            => All().First();
 
         public IEnumerable<SDVersion> All()
-            => versions ?? Enumerable.Empty<SDVersion>();
+            // The version we want is specified by `default_version_id`, it's not just
+            // the latest. See GH #214. Thanks to @Starstrider42 for spotting this.
+            => versions?.OrderByDescending(v => v.id == default_version_id)
+                       ?? Enumerable.Empty<SDVersion>();
 
         /// <summary>
         /// Returns the path to the mod's home on SpaceDock