Uncheck checkbox after missing dependency error

KSP-CKAN · Apr 25, 2018 · 1827fba · 1827fba
1 parent 9e71f86
commit 1827fba
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 7 deletions.
diff --git a/GUI/GUIMod.cs b/GUI/GUIMod.cs
@@ -251,6 +251,10 @@ public void SetInstallChecked(DataGridViewRow row, bool? set_value_to = null)
                 if ((bool)install_cell.Value != IsInstallChecked)
                 {
                     install_cell.Value = IsInstallChecked;
+                    // These calls are needed to force the UI to update,
+                    // otherwise the checkbox will look checked when it's unchecked or vice versa
+                    row.DataGridView.RefreshEdit();
+                    row.DataGridView.Refresh();
                 }
             }
         }

diff --git a/GUI/Main.cs b/GUI/Main.cs
@@ -606,6 +606,17 @@ private async Task UpdateChangeSetAndConflicts(IRegistryQuerier registry)
                 // We can just rerun it as the ModInfoTabControl has been removed.
                 too_many_provides_thrown = true;
             }
+            catch (DependencyNotSatisfiedKraken k)
+            {
+                GUI.user.RaiseError(
+                    "{0} depends on {1}, which is not compatible with the currently installed version of KSP",
+                    k.parent,
+                    k.module
+                );
+
+                // Uncheck the box
+                MarkModForInstall(k.parent.identifier, true);
+            }
 
             if (too_many_provides_thrown)
             {

diff --git a/GUI/MainModList.cs b/GUI/MainModList.cs
@@ -591,13 +591,6 @@ public async Task<IEnumerable<ModChange>> ComputeChangeSetFromModList(
                 {
                     kraken = k;
                 }
-                catch (ModuleNotFoundKraken k)
-                {
-                    //We shouldn't need this. However the relationship provider will throw TMPs with incompatible mods.
-                    user.RaiseError("Module {0} has not been found. This may be because it is not compatible " +
-                                    "with the currently installed version of KSP", k.module);
-                    return null;
-                }
                 //Shouldn't get here unless there is a kraken.
                 var mod = await too_many_provides(kraken);
                 if (mod != null)