[FEAT/#67] bpm별 음악 재생 추가 & 비트 비동기 연결 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feat/#67-music
chattymin
reviewed
Sep 23, 2024
Comment on lines
+118
to
+121
| listOf( | ||
| async { playOrResumeSoundPool() }, | ||
| async { mediaPlayer.start() } | ||
| ).awaitAll() |
chattymin
reviewed
Sep 23, 2024
Comment on lines
+282
to
+290
| lifecycleScope.launch { | ||
| beatStream = 0 | ||
| listOf( | ||
| async { setSoundPoolAsync() }, | ||
| async { setMediaPlayerAsync() } | ||
| ).awaitAll() | ||
| isLoaded = true | ||
| setLoadingView(false) | ||
| } |
There was a problem hiding this comment.
놀랍게도 생긴건 비슷하지만 모두 다른 ,,,
chattymin
reviewed
Sep 23, 2024
|
|
||
| @AndroidEntryPoint | ||
| class StretchFragment : BaseFragment<FragmentStretchBinding>(R.layout.fragment_stretch) { | ||
|
|
||
| private val viewModel by activityViewModels<RhythmViewModel>() | ||
| private lateinit var soundPool: SoundPool |
There was a problem hiding this comment.
이거 fragment 둘다 있는거 같은데 activity에 하나 놔두고 공용으로 써도 될듯?
There was a problem hiding this comment.
음악 재생기를 하나로 합쳤다가는 ,,, 무시무시한 오류들을 맛보게 될 것 같아서 ,,,, 일단 두겠읍니다
chattymin
reviewed
Sep 23, 2024
| @@ -23,7 +23,7 @@ | |||
|
|
|||
| <string name="rhythm_tv_bit">%d비트</string> | |||
| <string name="rhythm_tv_bpm">%dbpm</string> | |||
| <string name="rhythm_tv_step">%d걸음</string> | |||
| <string name="rhythm_tv_step">%03d걸음</string> | |||
There was a problem hiding this comment.
이게 1이면 001로 뜨게 하는거죠?
만약에 1000들어오면 어떻게 됐었죠? 가물가물
There was a problem hiding this comment.
%03d은 최소 3자리라 잘 출력됨니당 ~~
chattymin
reviewed
Sep 23, 2024
presentation/src/main/java/com/kkkk/presentation/main/rhythm/RhythmFragment.kt
Show resolved
Hide resolved
chattymin
reviewed
Sep 23, 2024
| setDataSource( | ||
| File(requireContext().filesDir, viewModel.filename).absolutePath | ||
| ) | ||
| mediaPlayer = MediaPlayer.create(requireContext(), findMusicByBpm(viewModel.bpm)).apply { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
KakaoTalk_Video_2024-09-24-02-21-34.mp4