[UI/#12] onboarding #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marchbreeze
approved these changes
Jul 23, 2024
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
|
|
||
| supportFragmentManager.findFragmentById(R.id.fcv_onboarding) |
There was a problem hiding this comment.
요 친구도 아래 showStartFragment 함수에 같이 넣어주면 onCreate가 더 깔끔할 것 같은데, 어려울까나요?
Comment on lines
42
to
59
| private fun showStartFragment() { | ||
| supportFragmentManager.commit { | ||
| replace(R.id.fcv_onboarding, OnboardingStartFragment()) | ||
| } | ||
| } | ||
|
|
||
| private fun showMeasureFragment() { | ||
| supportFragmentManager.commit { | ||
| replace(R.id.fcv_onboarding, OnboardingMeasureFragment()) | ||
| } | ||
| startTimer() | ||
| } | ||
|
|
||
| private fun showEndFragment() { | ||
| supportFragmentManager.commit { | ||
| replace(R.id.fcv_onboarding, OnboardingEndFragment()) | ||
| } | ||
| } |
There was a problem hiding this comment.
요 친구들 제가 메인액티비티에 만들어둔 함수 활용해보면 commit 반복된느거 좀 줄일 수 있을 것 같은데 어떠세옹?
Comment on lines
+66
to
+72
| timer = object : CountDownTimer(60000, 1000) { | ||
| override fun onTick(millisUntilFinished: Long) {} | ||
|
|
||
| override fun onFinish() { | ||
| viewModel.setState(OnboardingState.END) | ||
| } | ||
| }.start() |
| private fun initButtonListener() { | ||
| with(binding) { | ||
| btnOnboardingEndStart.setOnClickListener { | ||
| viewModel.setState(OnboardingState.DONE) |
Comment on lines
20
to
25
| enum class OnboardingState { | ||
| START, | ||
| MEASURE, | ||
| END, | ||
| DONE | ||
| } |
There was a problem hiding this comment.
요친구 domain 모듈에 enums 폴더 만들어서 다른 이넘들과 같이 관리하는거 어떠세옹
There was a problem hiding this comment.
해당 enum이 domain에 있어야하는 이유가 없는 것 같습니다.
여러 화면에서 재사용 될 확장성이 없고(물론 미래를 모르긴 하지만...), 해당 화면에만 관여를 하는 enum이라고 생각합니다.
그래서 따로 패키지를 빼지도 않고 ViewModel에 그냥 뒀습니다.
오로지 화면에만 영향을 끼치고 서버통신시에도 해당 enum을 결과로 받는게 아닌, 통신결과에 따라 viewModel에서 enum을 방출할 것으로 예상되는데 domain이 아닌 presentaiton에 두는건 어떨까요?? @Marchbreeze
| android:layout_height="wrap_content" | ||
| android:layout_marginTop="54dp" | ||
| android:gravity="center" | ||
| android:text="보행속도를 측정합니다" |
There was a problem hiding this comment.
으악 깜빡했네요
전부다... 추출하겠습니다아....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
start_end.mp4
measure_end.mp4
measure_finish.mp4
📢 To Reviewers