Updating increment! function to avoid further PR

src/nlp/counters.jl

@@ -70,8 +70,12 @@ end
 
 Increment counter `s` of problem `nlp`.
 """
-@inline function increment!(nlp::AbstractNLPModel, s::Symbol)
-  setproperty!(nlp.counters, s, getproperty(nlp.counters, s) + 1)
+function increment!(nlp::AbstractNLPModel, s::Symbol)
+  NLPModels.increment!(nlp, Val(s))
+end
+
+for fun in fieldnames(Counters)
+  @eval $NLPModels.increment!(nlp::AbstractNLPModel, ::Val{$(Meta.quot(fun))}) = nlp.counters.$fun += 1
 end
 
 """

src/nls/counters.jl

@@ -101,6 +101,25 @@ for counter in fieldnames(Counters)
   end
 end
 
+"""
+    increment!(nls, s)
+
+Increment counter `s` of problem `nls`.
+"""
+function increment!(nls::AbstractNLSModel, s::Symbol)
+  NLPModels.increment!(nls, Val(s))
+end
+
+for fun in fieldnames(NLSCounters)
+  fun == :counters && continue
+  @eval $NLPModels.increment!(nls::AbstractNLSModel, ::Val{$(Meta.quot(fun))}) = nls.counters.$fun += 1
+end
+
+
+for fun in fieldnames(Counters)
+  @eval $NLPModels.increment!(nls::AbstractNLSModel, ::Val{$(Meta.quot(fun))}) = nls.counters.counters.$fun += 1
+end
+
 function LinearOperators.reset!(nls::AbstractNLSModel)
   reset!(nls.counters)
   return nls