Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JLArrays, Metal and AMDGPU extensions and S kwarg tests (rebased) #351

Merged
merged 12 commits into from
Nov 23, 2024

Conversation

dpo
Copy link
Member

@dpo dpo commented Oct 16, 2024

No description provided.

@dpo dpo force-pushed the nHackel-addJLarrays branch from 2744a1b to efd9a57 Compare October 16, 2024 23:00
@dpo
Copy link
Member Author

dpo commented Oct 16, 2024

@nHackel It looks like there's a dependency issue with Julia 1.6 (that should perhaps be abandoned at this point), and a test error with Julia 1: https://github.com/JuliaSmoothOptimizers/LinearOperators.jl/actions/runs/11375178950/job/31645355758?pr=351#step:6:495

Copy link
Contributor

Package name latest stable
AdaptiveRegularization
CaNNOLeS
FletcherPenaltySolver
JSOSolvers
JSOSuite
LLSModels
NLPModels
NLPModelsModifiers
PROPACK
PartiallySeparableNLPModels
PartiallySeparableSolvers
PartitionedStructures
PartitionedVectors
Percival
QuadraticModels
RipQP
SolverTools

Copy link
Contributor

Package name latest stable
AdaptiveRegularization
CaNNOLeS
FletcherPenaltySolver
JSOSolvers
JSOSuite
LLSModels
NLPModels
NLPModelsModifiers
PROPACK
PartiallySeparableNLPModels
PartiallySeparableSolvers
PartitionedStructures
PartitionedVectors
Percival
QuadraticModels
RipQP
SolverTools

@nHackel
Copy link
Contributor

nHackel commented Oct 17, 2024

I'll try to fix the test issue over the weekend.

W can probably bump the compat to 1.10 since that is the new LTS

@nHackel
Copy link
Contributor

nHackel commented Nov 1, 2024

@dpo if we want to update from LTS 1.6 to the current LTS 1.10, should we do that in a seperate PR?

I've also looked into the test failure and for me it only happens in a 1.11 version and it seems like the SymTriDiagonal array and its LinearOperator don't work for GPU arrays anyways. At least they didnt work for JLArrays and CuArrays when I tested it

@dpo
Copy link
Member Author

dpo commented Nov 22, 2024

@nHackel I just opened #355 to change from 1.6 to 1.10.

Maybe just comment out the SymTridiagonal unit tests?!

@nHackel
Copy link
Contributor

nHackel commented Nov 22, 2024

@dpo I don't have permission to edit this branch, but maybe I oversaw something.

I've fetched this branch to my fork and made a new PR to this branch with the test commented out. If there is a way that is more straightforward or convenient for you, let me know and I update it

Copy link
Contributor

Package name latest stable
AdaptiveRegularization
CaNNOLeS
FletcherPenaltySolver
JSOSolvers
JSOSuite
LLSModels
NLPModels
NLPModelsModifiers
PROPACK
PartiallySeparableNLPModels
PartiallySeparableSolvers
PartitionedStructures
PartitionedVectors
Percival
QuadraticModels
RipQP
SolverTools

@dpo dpo merged commit 42e4e36 into main Nov 23, 2024
54 of 64 checks passed
@dpo dpo deleted the nHackel-addJLarrays branch November 23, 2024 23:16
@dpo
Copy link
Member Author

dpo commented Nov 23, 2024

Many thanks @nHackel !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants