Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for the option warm-start #961

Merged
merged 2 commits into from
Feb 16, 2025

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Feb 15, 2025

#959
Return the correct solution if we do a warm-start with an exact solution.

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 91.93548% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.56%. Comparing base (9536ef7) to head (61d7fed).
Report is 46 commits behind head on main.

Files with missing lines Patch % Lines
src/cr.jl 66.66% 1 Missing ⚠️
src/craigmr.jl 50.00% 1 Missing ⚠️
src/lslq.jl 50.00% 1 Missing ⚠️
src/lsmr.jl 50.00% 1 Missing ⚠️
src/lsqr.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
- Coverage   94.68%   93.56%   -1.12%     
==========================================
  Files          45       47       +2     
  Lines        8027     9205    +1178     
==========================================
+ Hits         7600     8613    +1013     
- Misses        427      592     +165     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

amontoison and others added 2 commits February 15, 2025 11:04
* Fix breakage tests

* Update .github/workflows/Breakage.yml
@amontoison amontoison merged commit b10df4b into JuliaSmoothOptimizers:main Feb 16, 2025
36 of 39 checks passed
@amontoison amontoison deleted the fix_warmstart branch February 16, 2025 19:18
@farhadrclass
Copy link
Contributor

@amontoison thanks for the update :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants