-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SparseArrays an extension package #955
base: main
Are you sure you want to change the base?
Make SparseArrays an extension package #955
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #955 +/- ##
==========================================
- Coverage 94.68% 93.38% -1.30%
==========================================
Files 45 50 +5
Lines 8027 9175 +1148
==========================================
+ Hits 7600 8568 +968
- Misses 427 607 +180 ☔ View full report in Codecov by Sentry. |
Is not I can take care of that next week and do a new release. |
LinearAlgebra.jl is a big one, that one will take a bit more time. The goal is to get the whole SciML stack to have sparse support optional first. I'm not sure a LinearSolve.jl without Linear algebra is possible without a refactor of the interface so we can get the types and the norm function separate, but that might be a Julia v1.13 thing |
bump |
While this may seem a bit weird since the most normal case for Krylov subspace methods is on sparse arrays, there are multiple reasons for this. 1. SparseArrays pulls in SuiteSparse and thus GPL dependencies 2. This is by far the biggest part of the load. Normal Krylov.jl loads in about 8ms, but the SparseArrays part is ~150ms. So if you want to just work on operators, then you'd taking a decently sized hit. 3. This is required for downstream dependency reduction SciML/LinearSolve.jl#570
4b547d6
to
61df856
Compare
@ChrisRackauckas |
I'm not sure about that. |
While this may seem a bit weird since the most normal case for Krylov subspace methods is on sparse arrays, there are multiple reasons for this.